[cedet-semantic] semantic-grammar-mode bindings break convention

[Bo L. <bo...@dr...>]

Hi,

I have a minor complaint regarding semantic-grammar-mode. It binds
"\C-cm" and "\C-i" and overrides some of my global keybindings.
According to
http://www.gnu.org/software/emacs/manual/html_node/elisp/Major-Mode-Conventions.html#Major-Mode-Conventions
:

    The key sequences bound in a major mode keymap should usually
    start with C-c, followed by a control character, a digit, or {,
    }, <, >, : or ;. The other punctuation characters are reserved
    for minor modes, and ordinary letters are reserved for users.

Therefore I suggest changing it to something like the following.

Thanks!
-Bo


diff --git a/lisp/cedet/semantic/grammar.el b/lisp/cedet/semantic/grammar.el
index 4a18293..5ac8013 100644
--- a/lisp/cedet/semantic/grammar.el
+++ b/lisp/cedet/semantic/grammar.el
@@ -1201,8 +1201,8 @@ END is the limit of the search."
 
     (define-key km "\t"       'semantic-grammar-indent)
     (define-key km "\C-c\C-c" 'semantic-grammar-create-package)
-    (define-key km "\C-cm"    'semantic-grammar-find-macro-expander)
-    (define-key km "\C-cik"    'semantic-grammar-insert-keyword)
+    (define-key km "\C-c\C-m"    'semantic-grammar-find-macro-expander)
+    (define-key km "\C-c\C-i"    'semantic-grammar-insert-keyword)
 ;;  (define-key km "\C-cc"    'semantic-grammar-generate-and-load)
 ;;  (define-key km "\C-cr"    'semantic-grammar-generate-one-rule)