Re: [CEDET-devel] Compdb project type for EDE committed
Brought to you by:
zappo
From: Eric L. <er...@si...> - 2015-04-12 21:12:31
|
On 03/23/2015 09:26 PM, Alastair Rankine wrote: [...] > The buildbot, however, still seems to think that there is a ninja-build > executable installed, so it runs the relevant tests anyway, and they > fail. Not sure exactly what is going on there. I have verified on the > machines that I have access to (Debian, Fedora, MacOSX) that it does the > correct thing with and without the prerequisite software installed. Hi Alastair, I was looking at compdb.el to see if I could figure out this issue. One of the ways other external tools in cedet are made optional is by following a pattern in the lisp/cedet/cedet-<tool>.el files. I started doing this to have one place to configure each tool which might be used between different parts of CEDET. Each one has a specific version it checks for, the command name, a way to call the tool, and a function that checks the version output of the tool. The simplest example is probably cedet-graphviz. In this way, your code could issue a message if the ninja tool is installed, but the version is wrong, or if it can't run for some reason. The test could then skip tests that require a working tool. I wasn't sure how to integrate that in for compdb as it seems that there were several levels of indirection. Perhaps you could use functions instead of doing the calls directly? I'll let you decide the best course. Thanks Eric |