Re: [CEDET-devel] Problems with completion of inherited functions outside of local scope
Brought to you by:
zappo
From: Eric M. L. <er...@si...> - 2009-10-08 15:36:23
|
Thanks for pointing that out. You are right. The calculation of the miniscope moved point, which invalidated the original scope, preventing it from providing the right kind of data. I checked in a change using save-excursion which re-enabled your test case. I still need to add some tests though. Now I worry that the moved point is needed for something related to the tmpscope, but none of my tests caught such a thing. I hadn't realized that cursor location was still important in this code. Eric On Thu, 2009-10-08 at 14:58 +0200, David Engster wrote: > Eric M. Ludlam <er...@si...> writes: > > This I can now replicate this. I suspect this is caused by all that > > work we did to restrict the search for parent classes based on the > > context of the issuing class. (For namespaces, aliases, etc.) I > > suspect semantic-analyze-fcn.el line 296. This would imply that if that > > call fails, we do whatever was in this history of this file, or > > vice-versa. > > Yes, it's a regression. I tested this with 1.0pre6, and it worked > there. However, I don't see how that part of semantic-analyze-fcn.el is > involved. Instead, I could track it down to the change in > semantic-analyze-scoped-inherited-tag-map, where you introduced the > 'mini scope': > > Date: Tue Aug 18 03:07:03 2009 +0000 > > (semantic-analyze-scoped-inherited-tag-map): > Add section to calculate a new miniscope to use when looking up the > parent in case the name provided in the parent of TYPE can only be > found in that scope. > > I'm a bit puzzled, since next to the new 'mini' scope it also queries > the original scope: > > (or (semantic-analyze-find-tag ps 'type tmpscope) > ;; A backup hack. > (semantic-analyze-find-tag ps 'type scope)) > > But it seems this is somehow not working. > > Regards, > David > > > ------------------------------------------------------------------------------ > Come build with us! The BlackBerry(R) Developer Conference in SF, CA > is the only developer event you need to attend this year. Jumpstart your > developing skills, take BlackBerry mobile applications to market and stay > ahead of the curve. Join us from November 9 - 12, 2009. Register now! > http://p.sf.net/sfu/devconference > _______________________________________________ > Cedet-devel mailing list > Ced...@li... > https://lists.sourceforge.net/lists/listinfo/cedet-devel |