Re: [CEDET-devel] Trouble Bu8ilding ceded from CVS with XEmacs

[<kla...@ca...>]

Hi guys,

I suggest the following change for semantic--format-colorize-text:

(defun semantic--format-colorize-text (text face-class)
  "Apply onto TEXT a color associated with FACE-CLASS.
FACE-CLASS is a tag type found in `semantic-face-alist'.  See this variable
for details on adding new types."
  (if (featurep 'font-lock)
      (let ((face (cdr-safe (assoc face-class semantic-format-face-alist)))
            (newtext (concat text)))
        (put-text-property 0 (length text) 'face face newtext)
        newtext)
    text))

With this change at least the un-colorized text is returned if font-lock is not loaded - with the old implementation in this case nil was returned - and IMHO this is not what the user wants... With this change using all the semantic-format-functions work also when called with COLOR-arg not nil but font-lock not enabled/loaded - then they simply do no colorizing but at least they display something (with current impl they display nothing ;-)

Thoughts?

Thanks a lot!
Klaus