[Cdrdao-devel] Patch to fix '--with-cddb' option not using 'cddb_server_list' value

[Philip T. <pj...@ie...>]

I noticed that cdrdao ignores the 'cddb_server_list' setting in 
/etc/cdrdao.conf when using the '--with-cddb' option with the 'read-cd' 
command, but that it observes the setting with the 'read-cddb' command.

I found in 'dao/main.cc' that the code section that applies the 
configuration file value, (overriding the default setting), is 
conditional on the command which is being run (read-cd, copy-cd, etc.), 
and, if the command is not 'read-cddb', also conditional on the value of 
a flag which seems intended to be set if the '--with-cddb' option is 
present.  Unfortunately, this code section is executed before the 
command-line is parsed, so this flag ('WITH_CDDB') is always clear.

The attached simple patch eliminates the test for the flag.  It seems to 
me harmless that the CDDB settings are in effect for commands that don't 
need them, but perhaps I missed some subtlety of the code - so, use at 
your own risk.  It works for me.

Philip J. Tait