[Cdk-devel] [ cdk-Bugs-815217 ] Make TemplateHandler more accessible

[SourceForge.net <no...@so...>]

Bugs item #815217, was opened at 2003-09-30 18:12
Message generated for change (Comment added) made by steinbeck
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=120024&aid=815217&group_id=20024

Category: org.openscience.cdk.layout
Group: None
>Status: Closed
>Resolution: Fixed
Priority: 5
Submitted By: Anatoli Krassavine (akrassavine)
Assigned to: Christoph Steinbeck (steinbeck)
Summary: Make TemplateHandler more accessible

Initial Comment:
Ability to specify resolved templates inside 
TemplateHandler is a great idea. Nevertheless the class 
itself should be made more accessible.

Presently the only way to load templates into 
TemplateHandler is via loadTemplates() which looks for 
a fixed system resource "data/templates/templates.list" 
and loads data from there. If it fails - it shows error 
message and does nothing else.

I would like to have methods which would allow me to
add/remove templates manually at runtime.

Proposal:

1) keep loadTemplates() - it is useful for default setup

2) add method 

public Molecule addTemplate(Molecule mol)

  loads pre-loaded template from whatever resource I 
need at runtime. Returns old template if it existed (it 
will be replaced by a new one). The template is replaced 
if it matches by substructure match, not nessesarily the 
same instance.

3) add method 

public boolean removeTemplate(Molecule mol)
returns TRUE if template was successfully removed, 
false otherwise. The template is removed if it matches 
by substructure match, not nessesarily the same 
instance.

----------------------------------------------------------------------

>Comment By: Christoph Steinbeck (steinbeck)
Date: 2004-02-09 23:22

Message:
Logged In: YES 
user_id=54358

Implemented this feature. 
You would now create an instance of
StructureDiagramGenerator, then use sdg.getTemplateHander()
to get an sdg's instance of a templateHander and then do
add/removeTemplate as requested. Please refer to
TemplateHandlerTest for a closer look.

----------------------------------------------------------------------

Comment By: Egon Willighagen (egonw)
Date: 2004-02-09 13:15

Message:
Logged In: YES 
user_id=25678

Scheduled to be implemented tomorrow. 

----------------------------------------------------------------------

Comment By: Christoph Steinbeck (steinbeck)
Date: 2003-09-30 18:55

Message:
Logged In: YES 
user_id=54358

Good point. This will have to wait for a while because of
two scientific meetings ahead. So you better implement that
yourself and contribute the code. Or you wait :-)


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=120024&aid=815217&group_id=20024