Re: [Cdk-devel] Strange code line in "PseudoAtom" class that may cause a bug.

[E.L. W. <eg...@sc...>]

On Wednesday 07 January 2004 08:42, M.Le_maudit wrote:
> In the PseudoAtom Class file, (v 1.10), there is something that I found to
> be strange. (PseudoAtom class is part of the org.openscience.cdk package.)
>
> Please, have a look at the constructor with the following signature (line
> 71) :
> [code] public PseudoAtom(Atom atom) [/code]
>
> The strange line code is this one :
> [code] this.fractionalPoint3D = fractionalPoint3D; [/code]
>
> This instruction is equivalent to :
> [code] this.fractionalPoint3D = this.fractionalPoint3D; [/code]
>
> So this line of code should be remove because it has no effect.
> ( I suppose this is not the right option. ;-) )
>
> But, maybe you intended to write :
> [code] this.fractionalPoint3D = atom.fractionalPoint3D; [/code]

Yes, that's what it should have been. Thanx for reporting this. I'm working on 
a fix (which mostly consists of writing a JUnit test...)

Egon

-- 
eg...@sc...
PhD on Molecular Representation in Chemometrics
Nijmegen University
http://www.cac.sci.kun.nl/people/egonw/
GPG: 1024D/D6336BA6