Re: [Cdk-jchempaint] about the forking...

[Egon W. <ego...@gm...>]

On Sat, May 26, 2012 at 5:34 PM,  <ra...@ar...> wrote:
> that means JCP uses its own Renderer? I agree this belongs
> in CDK. Ideally, I would have a FSM (Unimod) and GUI-specific code
> only in JCP.

Indeed.

> OTOH, your Controller code in cdk is too UI-specific,

Then we need to fix that. It's hard not to accidentally introduce AWT
stuff... and sometimes you cannot do but that...

But, there are these 'modules for a reason:

controller, controllerawt, etc..

That is, the code introduces a layer to make sure it is compatible
with SWT and with Swing mouse events... that is, for each one
implements the common interface...

> I think, this really belongs in the app. I agree that cursor is not
> a Renderer part, so this will lead to redesign, and I might well
> start with that.

I have not yet figured out what that patch is actually about... they
change the cursor under certain situations?

> The goal would be to use the cdk Renderer, with
> backporting to cdk what's worthwhile.

Cool. I was hoping you would say that :)

> But I'm still only skimming it all, so please forgive any
> foolishness.

Forgiven. I am merely one-eye in the land of the blind here, with
respect to the JChemPaint 3.x code...

Where I won't have a lot of time for coding, I will support your
efforts with explaining the CDK/CDK-JChemPaint code and design, make
sure you talk to the right people, (e.g. meet Arvid who works with the
Bioclipse team in Uppsala and on the SWT layers and a lot in core
renderer/controller development too, and he is the key person to talk
about ensuring we do not sneak in Swing/AWT specific things),
approving patches for the core CDK library, etc...

Egon


-- 
Dr E.L. Willighagen
Postdoctoral Researcher
Department of Bioinformatics - BiGCaT
Maastricht University (http://www.bigcat.unimaas.nl/)
Homepage: http://egonw.github.com/
LinkedIn: http://se.linkedin.com/in/egonw
Blog: http://chem-bla-ics.blogspot.com/
PubList: http://www.citeulike.org/user/egonw/tag/papers