Menu
▾
▴
[Cdk-commits] [cdk/cdk] b3335d: Render extra module with rendering functionality b...
|
From: GitHub <no...@gi...> - 2012-05-19 09:26:06
|
Branch: refs/heads/cdk-1.4.x Home: https://github.com/cdk/cdk Commit: b3335de246d586304805ce06964a667fd0fd98a5 https://github.com/cdk/cdk/commit/b3335de246d586304805ce06964a667fd0fd98a5 Author: Egon Willighagen <ego...@gm...> Date: 2012-05-19 (Sat, 19 May 2012) Changed paths: M build.xml M javadoc.xml M pmd-migrating.xml M pmd-unused.xml M pmd.xml A src/META-INF/renderextra.cdkdepends A src/META-INF/renderextra.libdepends A src/META-INF/test-renderextra.cdkdepends A src/META-INF/test-renderextra.devellibdepends A src/META-INF/test-renderextra.libdepends A src/main/org/openscience/cdk/renderer/Renderer.java A src/main/org/openscience/cdk/renderer/elements/AtomMassSymbolElement.java A src/main/org/openscience/cdk/renderer/generators/AtomContainerBoundsGenerator.java A src/main/org/openscience/cdk/renderer/generators/AtomMassGenerator.java A src/main/org/openscience/cdk/renderer/generators/AtomNumberGenerator.java A src/main/org/openscience/cdk/renderer/generators/BoundsGenerator.java A src/main/org/openscience/cdk/renderer/generators/ExtendedAtomGenerator.java A src/main/org/openscience/cdk/renderer/generators/IReactionGenerator.java A src/main/org/openscience/cdk/renderer/generators/LonePairGenerator.java A src/main/org/openscience/cdk/renderer/generators/MappingGenerator.java A src/main/org/openscience/cdk/renderer/generators/ProductsBoxGenerator.java A src/main/org/openscience/cdk/renderer/generators/RadicalGenerator.java A src/main/org/openscience/cdk/renderer/generators/ReactantsBoxGenerator.java A src/main/org/openscience/cdk/renderer/generators/ReactionArrowGenerator.java A src/main/org/openscience/cdk/renderer/generators/ReactionBoxGenerator.java A src/main/org/openscience/cdk/renderer/generators/ReactionPlusGenerator.java A src/main/org/openscience/cdk/renderer/visitor/DistanceSearchVisitor.java A src/main/org/openscience/cdk/renderer/visitor/PrintVisitor.java A src/test/org/openscience/cdk/coverage/RenderextraCoverageTest.java A src/test/org/openscience/cdk/modulesuites/MrenderextraTests.java Log Message: ----------- Render extra module with rendering functionality beyond IAtomContainers. * adds rendering of reactions * added javadoc and PMD testing * added module test suite * new modules: renderextra and test-renderextra Commit: 462140720c5f06ff2ca1bdbc8c20fcbb425d9eeb https://github.com/cdk/cdk/commit/462140720c5f06ff2ca1bdbc8c20fcbb425d9eeb Author: Egon Willighagen <ego...@gm...> Date: 2012-05-19 (Sat, 19 May 2012) Changed paths: M src/main/org/openscience/cdk/renderer/generators/AtomContainerBoundsGenerator.java M src/main/org/openscience/cdk/renderer/generators/AtomNumberGenerator.java M src/main/org/openscience/cdk/renderer/generators/LonePairGenerator.java M src/main/org/openscience/cdk/renderer/generators/RadicalGenerator.java Log Message: ----------- Updated for the new IGenerator.getParameters() interface method Commit: 980548cdb766edc13f6439d64e571be6edb7791b https://github.com/cdk/cdk/commit/980548cdb766edc13f6439d64e571be6edb7791b Author: Egon Willighagen <ego...@gm...> Date: 2012-05-19 (Sat, 19 May 2012) Changed paths: M src/META-INF/renderextra.cdkdepends Log Message: ----------- Added missing dependency on cdk-annotation, needed for TestClass Commit: 748343c10f710bfe737c471be1f71adc3310643b https://github.com/cdk/cdk/commit/748343c10f710bfe737c471be1f71adc3310643b Author: Egon Willighagen <ego...@gm...> Date: 2012-05-19 (Sat, 19 May 2012) Changed paths: M src/main/org/openscience/cdk/renderer/generators/AtomMassGenerator.java Log Message: ----------- Updated for the ILoggingTool patch. Commit: 1f30556b14e4fa42f6c0333753e321da92bf1c14 https://github.com/cdk/cdk/commit/1f30556b14e4fa42f6c0333753e321da92bf1c14 Author: Egon Willighagen <ego...@gm...> Date: 2012-05-19 (Sat, 19 May 2012) Changed paths: M src/main/org/openscience/cdk/renderer/Renderer.java Log Message: ----------- Fixed the Renderer to implement IRenderer Commit: 1414fc35dea636adbb2bcbafb31a80f556068fd6 https://github.com/cdk/cdk/commit/1414fc35dea636adbb2bcbafb31a80f556068fd6 Author: Arvid Berg <gog...@us...> Date: 2012-05-19 (Sat, 19 May 2012) Changed paths: M src/main/org/openscience/cdk/renderer/generators/AtomContainerBoundsGenerator.java M src/main/org/openscience/cdk/renderer/generators/AtomNumberGenerator.java M src/main/org/openscience/cdk/renderer/generators/LonePairGenerator.java M src/main/org/openscience/cdk/renderer/generators/RadicalGenerator.java Log Message: ----------- Changed getParameters() to use IGeneratorParameter<?> so that any type of IGeneratorParamter can be contained in the list. Signed-off-by: Egon Willighagen <ego...@gm...> Commit: 71daa52f1b449e099585ac7ce363ff8ca082679c https://github.com/cdk/cdk/commit/71daa52f1b449e099585ac7ce363ff8ca082679c Author: Egon Willighagen <ego...@gm...> Date: 2012-05-19 (Sat, 19 May 2012) Changed paths: M src/main/org/openscience/cdk/renderer/generators/AtomMassGenerator.java M src/main/org/openscience/cdk/renderer/generators/ExtendedAtomGenerator.java Log Message: ----------- Updated for the move of the rendering parameters for atom draw colors to the new IGeneratorParameter API Commit: fde3785a66e96568ae703b4ba7960e295af8540c https://github.com/cdk/cdk/commit/fde3785a66e96568ae703b4ba7960e295af8540c Author: Egon Willighagen <ego...@gm...> Date: 2012-05-19 (Sat, 19 May 2012) Changed paths: M src/main/org/openscience/cdk/renderer/Renderer.java Log Message: ----------- Set up a API to retrieve a IRenderingParameter from the RenderModel Commit: 8bf0d4e2176d915eff610eac92232bb31642d7a4 https://github.com/cdk/cdk/commit/8bf0d4e2176d915eff610eac92232bb31642d7a4 Author: Egon Willighagen <ego...@gm...> Date: 2012-05-19 (Sat, 19 May 2012) Changed paths: M src/main/org/openscience/cdk/renderer/generators/LonePairGenerator.java M src/main/org/openscience/cdk/renderer/generators/RadicalGenerator.java Log Message: ----------- Moved the atom radius into the new rendering parameter API (renderextra module) Commit: b8576d7052d4cffbc1c8f482ac2009b70020302d https://github.com/cdk/cdk/commit/b8576d7052d4cffbc1c8f482ac2009b70020302d Author: Arvid Berg <gog...@us...> Date: 2012-05-19 (Sat, 19 May 2012) Changed paths: M src/main/org/openscience/cdk/renderer/generators/AtomNumberGenerator.java Log Message: ----------- Added ability to generate atom number at an offset. This is a naive solution but allows for better looking rendering that the numbers rendered on top of the atom. Commit: 7eea4768ed6f3bb9ea3244016868ded1c912d9cc https://github.com/cdk/cdk/commit/7eea4768ed6f3bb9ea3244016868ded1c912d9cc Author: Egon Willighagen <ego...@gm...> Date: 2012-05-19 (Sat, 19 May 2012) Changed paths: M src/main/org/openscience/cdk/renderer/generators/ExtendedAtomGenerator.java Log Message: ----------- Updated for more IGeneratorParameter changes in BasicAtomGenerator Commit: 5475abdac06d2f6dc718d061cb8bc50b3b67d269 https://github.com/cdk/cdk/commit/5475abdac06d2f6dc718d061cb8bc50b3b67d269 Author: Egon Willighagen <ego...@gm...> Date: 2012-05-19 (Sat, 19 May 2012) Changed paths: M src/main/org/openscience/cdk/renderer/Renderer.java Log Message: ----------- Converted margin into the RenderingParameter variant Commit: 2dd9085f278ef10f62dc9ac15d8ae2c558f05939 https://github.com/cdk/cdk/commit/2dd9085f278ef10f62dc9ac15d8ae2c558f05939 Author: Egon Willighagen <ego...@gm...> Date: 2012-05-19 (Sat, 19 May 2012) Changed paths: M src/main/org/openscience/cdk/renderer/Renderer.java Log Message: ----------- Converted FontName and FontStyle into IGeneratorParameters Commit: 5b6507878180c041e850aff9dc952dc3e41b6c47 https://github.com/cdk/cdk/commit/5b6507878180c041e850aff9dc952dc3e41b6c47 Author: Egon Willighagen <ego...@gm...> Date: 2012-05-19 (Sat, 19 May 2012) Changed paths: M src/main/org/openscience/cdk/renderer/generators/ExtendedAtomGenerator.java Log Message: ----------- Refactored showIm/ExplicitHydrogens as IGeneratorParameter Commit: 242c16561052e6e704407492dd850215fdead286 https://github.com/cdk/cdk/commit/242c16561052e6e704407492dd850215fdead286 Author: Egon Willighagen <ego...@gm...> Date: 2012-05-19 (Sat, 19 May 2012) Changed paths: M src/main/org/openscience/cdk/renderer/generators/ProductsBoxGenerator.java M src/main/org/openscience/cdk/renderer/generators/ReactantsBoxGenerator.java M src/main/org/openscience/cdk/renderer/generators/ReactionArrowGenerator.java M src/main/org/openscience/cdk/renderer/generators/ReactionBoxGenerator.java M src/main/org/openscience/cdk/renderer/generators/ReactionPlusGenerator.java Log Message: ----------- Refactored foreground color into a IGeneratorParameter Commit: cb8652183805b2bd388366e93af0836838300659 https://github.com/cdk/cdk/commit/cb8652183805b2bd388366e93af0836838300659 Author: Egon Willighagen <ego...@gm...> Date: 2012-05-19 (Sat, 19 May 2012) Changed paths: M src/main/org/openscience/cdk/renderer/Renderer.java M src/main/org/openscience/cdk/renderer/generators/BoundsGenerator.java M src/main/org/openscience/cdk/renderer/generators/IReactionGenerator.java M src/main/org/openscience/cdk/renderer/generators/MappingGenerator.java M src/main/org/openscience/cdk/renderer/generators/ProductsBoxGenerator.java M src/main/org/openscience/cdk/renderer/generators/ReactantsBoxGenerator.java M src/main/org/openscience/cdk/renderer/generators/ReactionArrowGenerator.java M src/main/org/openscience/cdk/renderer/generators/ReactionBoxGenerator.java M src/main/org/openscience/cdk/renderer/generators/ReactionPlusGenerator.java Log Message: ----------- IReactionGenerator now has parameters too Commit: 841fb90bcb5028b80f1936822b1ce12daf7a875e https://github.com/cdk/cdk/commit/841fb90bcb5028b80f1936822b1ce12daf7a875e Author: Egon Willighagen <ego...@gm...> Date: 2012-05-19 (Sat, 19 May 2012) Changed paths: M src/main/org/openscience/cdk/renderer/generators/MappingGenerator.java M src/main/org/openscience/cdk/renderer/generators/ProductsBoxGenerator.java M src/main/org/openscience/cdk/renderer/generators/ReactantsBoxGenerator.java M src/main/org/openscience/cdk/renderer/generators/ReactionBoxGenerator.java A src/main/org/openscience/cdk/renderer/generators/ReactionSceneGenerator.java Log Message: ----------- Refactored reaction boxes into a IGeneratorParameter Commit: df620ea7191c7873f1ffa36627011c37e210f5ab https://github.com/cdk/cdk/commit/df620ea7191c7873f1ffa36627011c37e210f5ab Author: Egon Willighagen <ego...@gm...> Date: 2012-05-19 (Sat, 19 May 2012) Changed paths: M src/main/org/openscience/cdk/renderer/Renderer.java Log Message: ----------- Updated for the IGenerator/IAtomContainerGenerator refactoring Commit: e11b0612e81bccffedcdf9eccd4256b505242e17 https://github.com/cdk/cdk/commit/e11b0612e81bccffedcdf9eccd4256b505242e17 Author: Egon Willighagen <ego...@gm...> Date: 2012-05-19 (Sat, 19 May 2012) Changed paths: M src/main/org/openscience/cdk/renderer/generators/IReactionGenerator.java Log Message: ----------- Extend IGenerator which now provides getParameters() Commit: c59aa1862f727a64fa8a52e1f4636ebf6dd47acc https://github.com/cdk/cdk/commit/c59aa1862f727a64fa8a52e1f4636ebf6dd47acc Author: Stefan Kuhn <Ste...@eb...> Date: 2012-05-19 (Sat, 19 May 2012) Changed paths: M src/main/org/openscience/cdk/renderer/generators/RadicalGenerator.java Log Message: ----------- the RadicalGenerator can render atoms with more than one single electron. Signed-off-by: Arvid Berg <gog...@us...> Added rendering of more than one for vertical alignment too. And reverse direction on vertical alignment. Commit: bc7ce457edf22678835b6dfba3ede54985ec2abe https://github.com/cdk/cdk/commit/bc7ce457edf22678835b6dfba3ede54985ec2abe Author: Egon Willighagen <ego...@gm...> Date: 2012-05-19 (Sat, 19 May 2012) Changed paths: M src/main/org/openscience/cdk/renderer/Renderer.java M src/main/org/openscience/cdk/renderer/generators/AtomNumberGenerator.java M src/main/org/openscience/cdk/renderer/generators/LonePairGenerator.java M src/main/org/openscience/cdk/renderer/generators/MappingGenerator.java M src/main/org/openscience/cdk/renderer/generators/ProductsBoxGenerator.java M src/main/org/openscience/cdk/renderer/generators/RadicalGenerator.java M src/main/org/openscience/cdk/renderer/generators/ReactantsBoxGenerator.java M src/main/org/openscience/cdk/renderer/generators/ReactionArrowGenerator.java M src/main/org/openscience/cdk/renderer/generators/ReactionBoxGenerator.java M src/main/org/openscience/cdk/renderer/generators/ReactionSceneGenerator.java Log Message: ----------- Converted zoomFactor, scale, bondLength, and arrowHeadWidth to the new rendering parameter API Commit: f771866d1a861ce3e4963e9775e0d3ffe1c7de0f https://github.com/cdk/cdk/commit/f771866d1a861ce3e4963e9775e0d3ffe1c7de0f Author: Egon Willighagen <ego...@gm...> Date: 2012-05-19 (Sat, 19 May 2012) Changed paths: M src/main/org/openscience/cdk/renderer/generators/BoundsGenerator.java Log Message: ----------- Converted boundsColor to the new rendering parameter API Commit: 506377f068b9ac82c3af8442bda58c8c6f8de565 https://github.com/cdk/cdk/commit/506377f068b9ac82c3af8442bda58c8c6f8de565 Author: Egon Willighagen <ego...@gm...> Date: 2012-05-19 (Sat, 19 May 2012) Changed paths: M src/main/org/openscience/cdk/renderer/generators/MappingGenerator.java Log Message: ----------- Converted mappingColor and mappingLineWidth to the new rendering parameter API Commit: ec9a21e773d8504e64a54f55999202e6df7dba64 https://github.com/cdk/cdk/commit/ec9a21e773d8504e64a54f55999202e6df7dba64 Author: Egon Willighagen <ego...@gm...> Date: 2012-05-19 (Sat, 19 May 2012) Changed paths: M src/main/org/openscience/cdk/renderer/Renderer.java M src/main/org/openscience/cdk/renderer/generators/AtomContainerBoundsGenerator.java M src/main/org/openscience/cdk/renderer/generators/AtomNumberGenerator.java M src/main/org/openscience/cdk/renderer/generators/BoundsGenerator.java R src/main/org/openscience/cdk/renderer/generators/IReactionGenerator.java M src/main/org/openscience/cdk/renderer/generators/LonePairGenerator.java M src/main/org/openscience/cdk/renderer/generators/MappingGenerator.java M src/main/org/openscience/cdk/renderer/generators/ProductsBoxGenerator.java M src/main/org/openscience/cdk/renderer/generators/RadicalGenerator.java M src/main/org/openscience/cdk/renderer/generators/ReactantsBoxGenerator.java M src/main/org/openscience/cdk/renderer/generators/ReactionArrowGenerator.java M src/main/org/openscience/cdk/renderer/generators/ReactionBoxGenerator.java M src/main/org/openscience/cdk/renderer/generators/ReactionPlusGenerator.java M src/main/org/openscience/cdk/renderer/generators/ReactionSceneGenerator.java Log Message: ----------- Removed IAtomContainerGenerator and IReactionGenerator in favor if using generics: IGenerator<T extends IChemObject> (renderextra). Commit: 63b253cc164185dfb6bea84b732b737b18d350f9 https://github.com/cdk/cdk/commit/63b253cc164185dfb6bea84b732b737b18d350f9 Author: maclean <gil...@gm...> Date: 2012-05-19 (Sat, 19 May 2012) Changed paths: M src/main/org/openscience/cdk/renderer/Renderer.java M src/main/org/openscience/cdk/renderer/generators/AtomNumberGenerator.java M src/main/org/openscience/cdk/renderer/generators/ExtendedAtomGenerator.java Log Message: ----------- Changed wedge width to rendering parameter Commit: 3d8b4204ce664288c11c1befb8f3e05ecc23f355 https://github.com/cdk/cdk/commit/3d8b4204ce664288c11c1befb8f3e05ecc23f355 Author: Egon Willighagen <ego...@gm...> Date: 2012-05-19 (Sat, 19 May 2012) Changed paths: M src/main/org/openscience/cdk/renderer/generators/AtomNumberGenerator.java M src/main/org/openscience/cdk/renderer/generators/ExtendedAtomGenerator.java Log Message: ----------- Fixed instantiation of rendering parameter fields, which resulted in NullPointerException (renderextra). Commit: 8b97071ed9e2cbb22446bfa611d4bf2074dce8d5 https://github.com/cdk/cdk/commit/8b97071ed9e2cbb22446bfa611d4bf2074dce8d5 Author: Arvid Berg <gog...@us...> Date: 2012-05-19 (Sat, 19 May 2012) Changed paths: M src/main/org/openscience/cdk/renderer/Renderer.java Log Message: ----------- Removed scale and zoom form renderer and replaced with values form the generator parameters Commit: 150e1ed7a02ee09407665340f4409e22f88dacc5 https://github.com/cdk/cdk/commit/150e1ed7a02ee09407665340f4409e22f88dacc5 Author: Egon Willighagen <ego...@gm...> Date: 2012-05-19 (Sat, 19 May 2012) Changed paths: M src/main/org/openscience/cdk/renderer/Renderer.java M src/main/org/openscience/cdk/renderer/generators/AtomNumberGenerator.java M src/main/org/openscience/cdk/renderer/generators/ExtendedAtomGenerator.java M src/main/org/openscience/cdk/renderer/generators/LonePairGenerator.java M src/main/org/openscience/cdk/renderer/generators/MappingGenerator.java M src/main/org/openscience/cdk/renderer/generators/ProductsBoxGenerator.java M src/main/org/openscience/cdk/renderer/generators/RadicalGenerator.java M src/main/org/openscience/cdk/renderer/generators/ReactantsBoxGenerator.java M src/main/org/openscience/cdk/renderer/generators/ReactionArrowGenerator.java M src/main/org/openscience/cdk/renderer/generators/ReactionBoxGenerator.java M src/main/org/openscience/cdk/renderer/generators/ReactionPlusGenerator.java Log Message: ----------- Renamed get/setRenderingParameter methods to shorter names (renderextra). Commit: b132ebb85e3777af307f7922562f18bb8da8327d https://github.com/cdk/cdk/commit/b132ebb85e3777af307f7922562f18bb8da8327d Author: Egon Willighagen <ego...@gm...> Date: 2012-05-19 (Sat, 19 May 2012) Changed paths: M src/main/org/openscience/cdk/renderer/generators/ExtendedAtomGenerator.java Log Message: ----------- Also return the parameters of the super class -a (renderextra). Commit: d0f718ab387f4505714a3b25c9799b1b047a541a https://github.com/cdk/cdk/commit/d0f718ab387f4505714a3b25c9799b1b047a541a Author: Egon Willighagen <ego...@gm...> Date: 2012-05-19 (Sat, 19 May 2012) Changed paths: M src/main/org/openscience/cdk/renderer/generators/AtomNumberGenerator.java Log Message: ----------- Converted the offset from a constructor parameter into a proper IRenderingParamater (renderextra). Commit: 4c8b255965a342ba7ee1b4a338c422453849d6fd https://github.com/cdk/cdk/commit/4c8b255965a342ba7ee1b4a338c422453849d6fd Author: Egon Willighagen <ego...@gm...> Date: 2012-05-19 (Sat, 19 May 2012) Changed paths: M src/main/org/openscience/cdk/renderer/generators/AtomNumberGenerator.java Log Message: ----------- Added rendering parameters for coloring the atom numbers by some scheme, e.g. by element type Commit: 8ca883f29be2fbeed2ae04eef6307fd73991b6e3 https://github.com/cdk/cdk/commit/8ca883f29be2fbeed2ae04eef6307fd73991b6e3 Author: Egon Willighagen <ego...@gm...> Date: 2012-05-19 (Sat, 19 May 2012) Changed paths: M src/main/org/openscience/cdk/renderer/visitor/DistanceSearchVisitor.java Log Message: ----------- Fixed some PMD warnings: longer variable names (renderextra). Commit: 023fde0fe25624847c28261a42196d78e4e0be62 https://github.com/cdk/cdk/commit/023fde0fe25624847c28261a42196d78e4e0be62 Author: Arvid Berg <gog...@us...> Date: 2012-05-19 (Sat, 19 May 2012) Changed paths: M src/main/org/openscience/cdk/renderer/Renderer.java Log Message: ----------- Mirror structures on Y-axis to compensate for different coordinate systems. Fixes bc-bug #1654 cdk-bug #2855247 Commit: 185f6f1069aba753e2932c1e93d7bf8dfd127566 https://github.com/cdk/cdk/commit/185f6f1069aba753e2932c1e93d7bf8dfd127566 Author: Arvid Berg <gog...@us...> Date: 2012-05-19 (Sat, 19 May 2012) Changed paths: M src/main/org/openscience/cdk/renderer/Renderer.java Log Message: ----------- Added null check to avoid NPE when no model is present Commit: cfcfb28a6853edd3c8a01d183d72db5d44c073c6 https://github.com/cdk/cdk/commit/cfcfb28a6853edd3c8a01d183d72db5d44c073c6 Author: Egon Willighagen <ego...@gm...> Date: 2012-05-19 (Sat, 19 May 2012) Changed paths: A src/main/org/openscience/cdk/renderer/MoleculeSetRenderer.java A src/main/org/openscience/cdk/renderer/ReactionRenderer.java A src/main/org/openscience/cdk/renderer/ReactionSetRenderer.java M src/main/org/openscience/cdk/renderer/Renderer.java M src/main/org/openscience/cdk/renderer/generators/BoundsGenerator.java M src/main/org/openscience/cdk/renderer/generators/ProductsBoxGenerator.java M src/main/org/openscience/cdk/renderer/generators/ReactantsBoxGenerator.java M src/main/org/openscience/cdk/renderer/generators/ReactionArrowGenerator.java M src/main/org/openscience/cdk/renderer/generators/ReactionBoxGenerator.java M src/main/org/openscience/cdk/renderer/generators/ReactionPlusGenerator.java Log Message: ----------- Refactored into IRenderer<T extends IChemObject> with modules implementations for IAtomContainer (the existing AtomContainerRenderer), IMoleculeSet, IReaction, IReactionSet, and IChemModel (all for from the existing, overloaded Renderer) (renderextra). Commit: 743455fabd53efc138474d08a391d17c0f4a1f94 https://github.com/cdk/cdk/commit/743455fabd53efc138474d08a391d17c0f4a1f94 Author: Egon Willighagen <ego...@gm...> Date: 2012-05-19 (Sat, 19 May 2012) Changed paths: A src/main/org/openscience/cdk/renderer/ChemModelRenderer.java R src/main/org/openscience/cdk/renderer/Renderer.java Log Message: ----------- Renamed the Renderer to ChemModelRenderer, following the naming pattern for the other IRenderer implementations Commit: 067e4dcb8e487e54fc85149a83fc5a638b56bdb9 https://github.com/cdk/cdk/commit/067e4dcb8e487e54fc85149a83fc5a638b56bdb9 Author: maclean <gil...@gm...> Date: 2012-05-19 (Sat, 19 May 2012) Changed paths: M src/main/org/openscience/cdk/renderer/ChemModelRenderer.java M src/main/org/openscience/cdk/renderer/MoleculeSetRenderer.java M src/main/org/openscience/cdk/renderer/ReactionRenderer.java M src/main/org/openscience/cdk/renderer/ReactionSetRenderer.java Log Message: ----------- More types in renderers, and associations between renderers Commit: 4f0ac1d3af1aa8a547568a628c0610498c377876 https://github.com/cdk/cdk/commit/4f0ac1d3af1aa8a547568a628c0610498c377876 Author: maclean <gil...@gm...> Date: 2012-05-19 (Sat, 19 May 2012) Changed paths: M src/main/org/openscience/cdk/renderer/ChemModelRenderer.java M src/main/org/openscience/cdk/renderer/MoleculeSetRenderer.java M src/main/org/openscience/cdk/renderer/ReactionRenderer.java M src/main/org/openscience/cdk/renderer/ReactionSetRenderer.java Log Message: ----------- Using IRenderer<T> interface instead of implementation Commit: 640e26a4600a1d5225f1f0b4f31136d7af17dd24 https://github.com/cdk/cdk/commit/640e26a4600a1d5225f1f0b4f31136d7af17dd24 Author: Egon Willighagen <ego...@gm...> Date: 2012-05-19 (Sat, 19 May 2012) Changed paths: M src/main/org/openscience/cdk/renderer/generators/AtomMassGenerator.java M src/main/org/openscience/cdk/renderer/generators/ExtendedAtomGenerator.java Log Message: ----------- Updated for API changes in CDK 1.3.6 (renderextra). Commit: 32ca540ec38708ef1ae04aad4bf5c854ad22ffaa https://github.com/cdk/cdk/commit/32ca540ec38708ef1ae04aad4bf5c854ad22ffaa Author: Egon Willighagen <ego...@gm...> Date: 2012-05-19 (Sat, 19 May 2012) Changed paths: M src/main/org/openscience/cdk/renderer/MoleculeSetRenderer.java M src/main/org/openscience/cdk/renderer/ReactionRenderer.java Log Message: ----------- Fixed registering of rendering parameters (renderextra). Commit: d13b1a24d01d3c7beb40f9e19e38fc084f47f628 https://github.com/cdk/cdk/commit/d13b1a24d01d3c7beb40f9e19e38fc084f47f628 Author: Egon Willighagen <ego...@gm...> Date: 2012-05-19 (Sat, 19 May 2012) Changed paths: M src/main/org/openscience/cdk/renderer/MoleculeSetRenderer.java Log Message: ----------- Fixed NullPointerException by creating an empty list of generators, and return a list too, rather than a null Commit: 2ffc5a1b152921f9af00e91465c4225ec18721bd https://github.com/cdk/cdk/commit/2ffc5a1b152921f9af00e91465c4225ec18721bd Author: Egon Willighagen <ego...@gm...> Date: 2012-05-19 (Sat, 19 May 2012) Changed paths: M src/main/org/openscience/cdk/renderer/MoleculeSetRenderer.java Log Message: ----------- Implemented the generateDiagram and use that in the paint methods, which fixes reaction rendering as the ReactionRenderer.generateDiagram() uses MoleculeSetRenderer.generateDiagram() Commit: 965c6514bab6c90bbbace8057f7f547b7ed09969 https://github.com/cdk/cdk/commit/965c6514bab6c90bbbace8057f7f547b7ed09969 Author: Egon Willighagen <ego...@gm...> Date: 2012-05-19 (Sat, 19 May 2012) Changed paths: M src/main/org/openscience/cdk/renderer/ReactionRenderer.java Log Message: ----------- Because the renderers are now typed itself, we can use this.generators instead, fixign a NullPointerException while rendering reactions Commit: 1f729ca6230f32661a96efd32388e0ff352b3349 https://github.com/cdk/cdk/commit/1f729ca6230f32661a96efd32388e0ff352b3349 Author: Egon Willighagen <ego...@gm...> Date: 2012-05-19 (Sat, 19 May 2012) Changed paths: M src/main/org/openscience/cdk/renderer/ChemModelRenderer.java M src/main/org/openscience/cdk/renderer/ReactionRenderer.java Log Message: ----------- Proper initialization at the primary renderer too. (renderextra). Commit: 0e28dd3d697a259a68041430458f3c282677eee7 https://github.com/cdk/cdk/commit/0e28dd3d697a259a68041430458f3c282677eee7 Author: Arvid Berg <gog...@us...> Date: 2012-05-19 (Sat, 19 May 2012) Changed paths: M src/main/org/openscience/cdk/renderer/generators/AtomMassGenerator.java M src/main/org/openscience/cdk/renderer/generators/ExtendedAtomGenerator.java Log Message: ----------- Uses RendererModel to get all GeneratorParameters If a generator serve as a base class for other generators the only instance that can be set is the one that was registered last, this commit fixes that by always look up the parameter from the model and thus will get the one that is in the model's registry. Commit: f37be8f419bc32869dc0acf54810a3bda663e36c https://github.com/cdk/cdk/commit/f37be8f419bc32869dc0acf54810a3bda663e36c Author: Egon Willighagen <ego...@gm...> Date: 2012-05-19 (Sat, 19 May 2012) Changed paths: M src/main/org/openscience/cdk/renderer/visitor/DistanceSearchVisitor.java M src/main/org/openscience/cdk/renderer/visitor/PrintVisitor.java Log Message: ----------- Fixing PMD warnings: more descriptive variable names (renderextra). Commit: 4dedcb0e942cc43062df61e1996d205c3a778f7f https://github.com/cdk/cdk/commit/4dedcb0e942cc43062df61e1996d205c3a778f7f Author: Egon Willighagen <ego...@gm...> Date: 2012-05-19 (Sat, 19 May 2012) Changed paths: M src/main/org/openscience/cdk/renderer/generators/ExtendedAtomGenerator.java Log Message: ----------- Check if the WillDrawAtomNumbers param is registered Commit: 2e352c32d659d7ca08017c56828c077016ea7d59 https://github.com/cdk/cdk/commit/2e352c32d659d7ca08017c56828c077016ea7d59 Author: Egon Willighagen <ego...@gm...> Date: 2012-05-19 (Sat, 19 May 2012) Changed paths: M src/main/org/openscience/cdk/renderer/generators/ExtendedAtomGenerator.java Log Message: ----------- Another check if the WillDrawAtomNumbers param is registered. Commit: 2ca2d5a68110e8cdd540afb130becf3bb97b0f30 https://github.com/cdk/cdk/commit/2ca2d5a68110e8cdd540afb130becf3bb97b0f30 Author: Egon Willighagen <ego...@gm...> Date: 2012-05-19 (Sat, 19 May 2012) Changed paths: M src/main/org/openscience/cdk/renderer/ChemModelRenderer.java M src/main/org/openscience/cdk/renderer/MoleculeSetRenderer.java M src/main/org/openscience/cdk/renderer/ReactionRenderer.java M src/main/org/openscience/cdk/renderer/ReactionSetRenderer.java M src/test/org/openscience/cdk/modulesuites/MrenderextraTests.java A src/test/org/openscience/cdk/renderer/ChemModelRendererTest.java A src/test/org/openscience/cdk/renderer/MoleculeSetRendererTest.java A src/test/org/openscience/cdk/renderer/ReactionRendererTest.java A src/test/org/openscience/cdk/renderer/ReactionSetRendererTest.java Log Message: ----------- Added missing *RendererTest classes, with basic tests for constructors Commit: b39757919c1efdccef81ba66cdc241cc34e02cf3 https://github.com/cdk/cdk/commit/b39757919c1efdccef81ba66cdc241cc34e02cf3 Author: Egon Willighagen <ego...@gm...> Date: 2012-05-19 (Sat, 19 May 2012) Changed paths: M src/main/org/openscience/cdk/renderer/generators/AtomContainerBoundsGenerator.java M src/main/org/openscience/cdk/renderer/generators/AtomNumberGenerator.java M src/main/org/openscience/cdk/renderer/generators/ExtendedAtomGenerator.java M src/main/org/openscience/cdk/renderer/generators/LonePairGenerator.java M src/main/org/openscience/cdk/renderer/generators/ProductsBoxGenerator.java M src/main/org/openscience/cdk/renderer/generators/RadicalGenerator.java M src/main/org/openscience/cdk/renderer/generators/ReactantsBoxGenerator.java M src/main/org/openscience/cdk/renderer/generators/ReactionArrowGenerator.java M src/main/org/openscience/cdk/renderer/generators/ReactionBoxGenerator.java M src/main/org/openscience/cdk/renderer/generators/ReactionPlusGenerator.java M src/main/org/openscience/cdk/renderer/generators/ReactionSceneGenerator.java M src/test/org/openscience/cdk/modulesuites/MrenderextraTests.java A src/test/org/openscience/cdk/renderer/generators/AtomContainerBoundsGeneratorTest.java A src/test/org/openscience/cdk/renderer/generators/AtomNumberGeneratorTest.java M src/test/org/openscience/cdk/renderer/generators/BasicSceneGeneratorTest.java A src/test/org/openscience/cdk/renderer/generators/ExtendedAtomGeneratorTest.java A src/test/org/openscience/cdk/renderer/generators/LonePairGeneratorTest.java A src/test/org/openscience/cdk/renderer/generators/ProductsBoxGeneratorTest.java A src/test/org/openscience/cdk/renderer/generators/RadicalGeneratorTest.java A src/test/org/openscience/cdk/renderer/generators/ReactantsBoxGeneratorTest.java A src/test/org/openscience/cdk/renderer/generators/ReactionArrowGeneratorTest.java A src/test/org/openscience/cdk/renderer/generators/ReactionBoxGeneratorTest.java A src/test/org/openscience/cdk/renderer/generators/ReactionPlusGeneratorTest.java A src/test/org/openscience/cdk/renderer/generators/ReactionSceneGeneratorTest.java Log Message: ----------- A bunch of test classes with minimal testing Commit: f5253818e4382e67b8daaea47b2f37aa5babaf94 https://github.com/cdk/cdk/commit/f5253818e4382e67b8daaea47b2f37aa5babaf94 Author: Egon Willighagen <ego...@gm...> Date: 2012-05-19 (Sat, 19 May 2012) Changed paths: M src/META-INF/test-renderextra.cdkdepends Log Message: ----------- Missing dep for new renderextra tests Commit: be0c5446cbae9b1425453775709df2207325ca26 https://github.com/cdk/cdk/commit/be0c5446cbae9b1425453775709df2207325ca26 Author: Egon Willighagen <ego...@gm...> Date: 2012-05-19 (Sat, 19 May 2012) Changed paths: R src/main/org/openscience/cdk/renderer/visitor/DistanceSearchVisitor.java Log Message: ----------- Removed DistanceSearchVisitor Commit: 2e1c7fa80cd8babf768edb5bb748b08749349152 https://github.com/cdk/cdk/commit/2e1c7fa80cd8babf768edb5bb748b08749349152 Author: Egon Willighagen <ego...@gm...> Date: 2012-05-19 (Sat, 19 May 2012) Changed paths: M src/META-INF/test-renderextra.cdkdepends Log Message: ----------- Added two more missing dependencies: interface implementations. Commit: f134813f722055c1906681d461baec4598397a6f https://github.com/cdk/cdk/commit/f134813f722055c1906681d461baec4598397a6f Author: Egon Willighagen <ego...@gm...> Date: 2012-05-19 (Sat, 19 May 2012) Changed paths: R src/main/org/openscience/cdk/renderer/visitor/PrintVisitor.java Log Message: ----------- Removed PrintVisitor Commit: 23f984272cb7e74324b3286df1eba4760a952c29 https://github.com/cdk/cdk/commit/23f984272cb7e74324b3286df1eba4760a952c29 Author: Egon Willighagen <ego...@gm...> Date: 2012-05-19 (Sat, 19 May 2012) Changed paths: M src/main/org/openscience/cdk/renderer/generators/AtomMassGenerator.java M src/main/org/openscience/cdk/renderer/generators/BoundsGenerator.java M src/main/org/openscience/cdk/renderer/generators/MappingGenerator.java A src/test/org/openscience/cdk/renderer/generators/AtomMassGeneratorTest.java A src/test/org/openscience/cdk/renderer/generators/BoundsGeneratorTest.java A src/test/org/openscience/cdk/renderer/generators/MappingGeneratorTest.java Log Message: ----------- Added the last three missing test classes Commit: cab344a194afbd8bbe5271cfbe1d5c5d6c8cfcc0 https://github.com/cdk/cdk/commit/cab344a194afbd8bbe5271cfbe1d5c5d6c8cfcc0 Author: Egon Willighagen <ego...@gm...> Date: 2012-05-19 (Sat, 19 May 2012) Changed paths: M src/test/org/openscience/cdk/modulesuites/MrenderextraTests.java M src/test/org/openscience/cdk/renderer/generators/AtomContainerBoundsGeneratorTest.java M src/test/org/openscience/cdk/renderer/generators/AtomMassGeneratorTest.java M src/test/org/openscience/cdk/renderer/generators/AtomNumberGeneratorTest.java M src/test/org/openscience/cdk/renderer/generators/BoundsGeneratorTest.java M src/test/org/openscience/cdk/renderer/generators/ExtendedAtomGeneratorTest.java M src/test/org/openscience/cdk/renderer/generators/LonePairGeneratorTest.java M src/test/org/openscience/cdk/renderer/generators/MappingGeneratorTest.java M src/test/org/openscience/cdk/renderer/generators/ProductsBoxGeneratorTest.java M src/test/org/openscience/cdk/renderer/generators/RadicalGeneratorTest.java M src/test/org/openscience/cdk/renderer/generators/ReactantsBoxGeneratorTest.java M src/test/org/openscience/cdk/renderer/generators/ReactionArrowGeneratorTest.java M src/test/org/openscience/cdk/renderer/generators/ReactionBoxGeneratorTest.java M src/test/org/openscience/cdk/renderer/generators/ReactionPlusGeneratorTest.java M src/test/org/openscience/cdk/renderer/generators/ReactionSceneGeneratorTest.java Log Message: ----------- Added testing in the abstract test class for general pattern that getParameters() should return a non-null List Commit: 729e73ef7c5b51365671523152e65fb636d9ab1d https://github.com/cdk/cdk/commit/729e73ef7c5b51365671523152e65fb636d9ab1d Author: Egon Willighagen <ego...@gm...> Date: 2012-05-19 (Sat, 19 May 2012) Changed paths: M src/main/org/openscience/cdk/renderer/generators/AtomContainerBoundsGenerator.java M src/main/org/openscience/cdk/renderer/generators/AtomNumberGenerator.java M src/main/org/openscience/cdk/renderer/generators/BoundsGenerator.java M src/main/org/openscience/cdk/renderer/generators/LonePairGenerator.java M src/main/org/openscience/cdk/renderer/generators/MappingGenerator.java M src/main/org/openscience/cdk/renderer/generators/ProductsBoxGenerator.java M src/main/org/openscience/cdk/renderer/generators/RadicalGenerator.java M src/main/org/openscience/cdk/renderer/generators/ReactantsBoxGenerator.java M src/main/org/openscience/cdk/renderer/generators/ReactionArrowGenerator.java M src/main/org/openscience/cdk/renderer/generators/ReactionBoxGenerator.java M src/main/org/openscience/cdk/renderer/generators/ReactionPlusGenerator.java M src/main/org/openscience/cdk/renderer/generators/ReactionSceneGenerator.java Log Message: ----------- Added TestMethod annotation for the getParameter() methods Commit: 54f54ce33edbe4ad45533fc1b652742111871f85 https://github.com/cdk/cdk/commit/54f54ce33edbe4ad45533fc1b652742111871f85 Author: Egon Willighagen <ego...@gm...> Date: 2012-05-19 (Sat, 19 May 2012) Changed paths: M src/main/org/openscience/cdk/renderer/ChemModelRenderer.java M src/main/org/openscience/cdk/renderer/MoleculeSetRenderer.java M src/main/org/openscience/cdk/renderer/ReactionRenderer.java M src/main/org/openscience/cdk/renderer/ReactionSetRenderer.java M src/main/org/openscience/cdk/renderer/elements/AtomMassSymbolElement.java M src/main/org/openscience/cdk/renderer/generators/AtomContainerBoundsGenerator.java M src/main/org/openscience/cdk/renderer/generators/AtomMassGenerator.java M src/main/org/openscience/cdk/renderer/generators/AtomNumberGenerator.java M src/main/org/openscience/cdk/renderer/generators/BoundsGenerator.java M src/main/org/openscience/cdk/renderer/generators/ExtendedAtomGenerator.java M src/main/org/openscience/cdk/renderer/generators/LonePairGenerator.java M src/main/org/openscience/cdk/renderer/generators/MappingGenerator.java M src/main/org/openscience/cdk/renderer/generators/ProductsBoxGenerator.java M src/main/org/openscience/cdk/renderer/generators/RadicalGenerator.java M src/main/org/openscience/cdk/renderer/generators/ReactantsBoxGenerator.java M src/main/org/openscience/cdk/renderer/generators/ReactionArrowGenerator.java M src/main/org/openscience/cdk/renderer/generators/ReactionBoxGenerator.java M src/main/org/openscience/cdk/renderer/generators/ReactionPlusGenerator.java M src/main/org/openscience/cdk/renderer/generators/ReactionSceneGenerator.java Log Message: ----------- Added missing @cdk.githash annotation Commit: 8e7300f20723f2315d3855fd7f62ec51ecc28ac2 https://github.com/cdk/cdk/commit/8e7300f20723f2315d3855fd7f62ec51ecc28ac2 Author: Egon Willighagen <ego...@gm...> Date: 2012-05-19 (Sat, 19 May 2012) Changed paths: M src/main/org/openscience/cdk/renderer/generators/AtomContainerBoundsGenerator.java M src/main/org/openscience/cdk/renderer/generators/AtomNumberGenerator.java M src/main/org/openscience/cdk/renderer/generators/BoundsGenerator.java M src/main/org/openscience/cdk/renderer/generators/ExtendedAtomGenerator.java M src/main/org/openscience/cdk/renderer/generators/LonePairGenerator.java M src/main/org/openscience/cdk/renderer/generators/MappingGenerator.java M src/main/org/openscience/cdk/renderer/generators/ProductsBoxGenerator.java M src/main/org/openscience/cdk/renderer/generators/RadicalGenerator.java M src/main/org/openscience/cdk/renderer/generators/ReactantsBoxGenerator.java M src/main/org/openscience/cdk/renderer/generators/ReactionArrowGenerator.java M src/main/org/openscience/cdk/renderer/generators/ReactionBoxGenerator.java M src/main/org/openscience/cdk/renderer/generators/ReactionPlusGenerator.java M src/main/org/openscience/cdk/renderer/generators/ReactionSceneGenerator.java Log Message: ----------- Inherit JavaDoc where possible Commit: d34f8b611b1cde004c9e677c13ea8c35f9e2036d https://github.com/cdk/cdk/commit/d34f8b611b1cde004c9e677c13ea8c35f9e2036d Author: Egon Willighagen <ego...@gm...> Date: 2012-05-19 (Sat, 19 May 2012) Changed paths: M src/main/org/openscience/cdk/renderer/generators/AtomMassGenerator.java Log Message: ----------- Removed an unused method Commit: b1b53647345787466003ee2763b20b41ee3aef97 https://github.com/cdk/cdk/commit/b1b53647345787466003ee2763b20b41ee3aef97 Author: Egon Willighagen <ego...@gm...> Date: 2012-05-19 (Sat, 19 May 2012) Changed paths: M src/test/org/openscience/cdk/renderer/generators/AtomMassGeneratorTest.java Log Message: ----------- Extend the test class for the super class of the class tested by this test Commit: 49043c9b4b125e6dab152ae59f4d9486ad94ab8d https://github.com/cdk/cdk/commit/49043c9b4b125e6dab152ae59f4d9486ad94ab8d Author: Egon Willighagen <ego...@gm...> Date: 2012-05-19 (Sat, 19 May 2012) Changed paths: M src/main/org/openscience/cdk/renderer/generators/AtomMassGenerator.java Log Message: ----------- Added missing TestMethod annotation Commit: 4c82b0b831d623d4ac96dbe01a8c0d1a855d47d2 https://github.com/cdk/cdk/commit/4c82b0b831d623d4ac96dbe01a8c0d1a855d47d2 Author: Egon Willighagen <ego...@gm...> Date: 2012-05-19 (Sat, 19 May 2012) Changed paths: M src/main/org/openscience/cdk/renderer/generators/BoundsGenerator.java Log Message: ----------- Removed an unused method and made another private Commit: a72cba10be11f9b50534d9813859a6c8debf89b5 https://github.com/cdk/cdk/commit/a72cba10be11f9b50534d9813859a6c8debf89b5 Author: Egon Willighagen <ego...@gm...> Date: 2012-05-19 (Sat, 19 May 2012) Changed paths: M src/main/org/openscience/cdk/renderer/generators/ExtendedAtomGenerator.java M src/test/org/openscience/cdk/renderer/generators/ExtendedAtomGeneratorTest.java Log Message: ----------- Removed an unused method, made a few methods private not required by the interface, and added a missing test method annotation; also extend the test class of the superclass of the tested class Commit: 8899eafc4d79e32aeb554eeb38bbe172897cb941 https://github.com/cdk/cdk/commit/8899eafc4d79e32aeb554eeb38bbe172897cb941 Author: Egon Willighagen <ego...@gm...> Date: 2012-05-19 (Sat, 19 May 2012) Changed paths: M src/main/org/openscience/cdk/renderer/generators/MappingGenerator.java M src/main/org/openscience/cdk/renderer/generators/ReactionPlusGenerator.java Log Message: ----------- Made two more methods private that are not required by the interface Commit: 07ccf7a9fae2addabe247c8d109314e8edd0ae87 https://github.com/cdk/cdk/commit/07ccf7a9fae2addabe247c8d109314e8edd0ae87 Author: Egon Willighagen <ego...@gm...> Date: 2012-05-19 (Sat, 19 May 2012) Changed paths: M src/main/org/openscience/cdk/renderer/ChemModelRenderer.java M src/main/org/openscience/cdk/renderer/MoleculeSetRenderer.java M src/main/org/openscience/cdk/renderer/ReactionRenderer.java M src/main/org/openscience/cdk/renderer/ReactionSetRenderer.java Log Message: ----------- Added missing JavaDoc or inherit it Commit: 56dcf576dce0597b8d2060992cc874b954745566 https://github.com/cdk/cdk/commit/56dcf576dce0597b8d2060992cc874b954745566 Author: Egon Willighagen <ego...@gm...> Date: 2012-05-19 (Sat, 19 May 2012) Changed paths: M src/main/org/openscience/cdk/renderer/MoleculeSetRenderer.java M src/main/org/openscience/cdk/renderer/ReactionRenderer.java M src/main/org/openscience/cdk/renderer/ReactionSetRenderer.java M src/main/org/openscience/cdk/renderer/elements/AtomMassSymbolElement.java M src/main/org/openscience/cdk/renderer/generators/AtomContainerBoundsGenerator.java M src/main/org/openscience/cdk/renderer/generators/AtomMassGenerator.java M src/main/org/openscience/cdk/renderer/generators/AtomNumberGenerator.java M src/main/org/openscience/cdk/renderer/generators/ExtendedAtomGenerator.java M src/main/org/openscience/cdk/renderer/generators/MappingGenerator.java M src/main/org/openscience/cdk/renderer/generators/ReactionSceneGenerator.java Log Message: ----------- Added last bits of missing JavaDoc Commit: 4da3504cd7e320796ec7acd86d0ec5d2bafcd62c https://github.com/cdk/cdk/commit/4da3504cd7e320796ec7acd86d0ec5d2bafcd62c Author: Egon Willighagen <ego...@gm...> Date: 2012-05-19 (Sat, 19 May 2012) Changed paths: M src/main/org/openscience/cdk/renderer/generators/BoundsGenerator.java Log Message: ----------- Removed an unused parameter from the private API Commit: b55da37b3a9727167a1b619915773dec6918f36b https://github.com/cdk/cdk/commit/b55da37b3a9727167a1b619915773dec6918f36b Author: Egon Willighagen <ego...@gm...> Date: 2012-05-19 (Sat, 19 May 2012) Changed paths: M src/main/org/openscience/cdk/renderer/MoleculeSetRenderer.java M src/main/org/openscience/cdk/renderer/elements/AtomMassSymbolElement.java M src/main/org/openscience/cdk/renderer/generators/AtomContainerBoundsGenerator.java M src/main/org/openscience/cdk/renderer/generators/AtomNumberGenerator.java M src/main/org/openscience/cdk/renderer/generators/ExtendedAtomGenerator.java M src/main/org/openscience/cdk/renderer/generators/LonePairGenerator.java M src/main/org/openscience/cdk/renderer/generators/MappingGenerator.java M src/main/org/openscience/cdk/renderer/generators/ProductsBoxGenerator.java M src/main/org/openscience/cdk/renderer/generators/RadicalGenerator.java M src/main/org/openscience/cdk/renderer/generators/ReactantsBoxGenerator.java M src/main/org/openscience/cdk/renderer/generators/ReactionArrowGenerator.java M src/main/org/openscience/cdk/renderer/generators/ReactionBoxGenerator.java M src/main/org/openscience/cdk/renderer/generators/ReactionPlusGenerator.java Log Message: ----------- More descriptive variable names Commit: a3f264262fbb7ce78161fe82da1e4c6f94b8504f https://github.com/cdk/cdk/commit/a3f264262fbb7ce78161fe82da1e4c6f94b8504f Author: Arvid Berg <gog...@gm...> Date: 2012-05-19 (Sat, 19 May 2012) Changed paths: M src/main/org/openscience/cdk/renderer/ChemModelRenderer.java M src/main/org/openscience/cdk/renderer/MoleculeSetRenderer.java M src/main/org/openscience/cdk/renderer/ReactionRenderer.java M src/main/org/openscience/cdk/renderer/ReactionSetRenderer.java Log Message: ----------- (renderextra). Pass the RendererModel to contained renderers. Commit: a613ca2b418362eda769e28a4302819b7c59d065 https://github.com/cdk/cdk/commit/a613ca2b418362eda769e28a4302819b7c59d065 Author: Arvid Berg <gog...@gm...> Date: 2012-05-19 (Sat, 19 May 2012) Changed paths: M src/main/org/openscience/cdk/renderer/MoleculeSetRenderer.java M src/main/org/openscience/cdk/renderer/ReactionSetRenderer.java Log Message: ----------- Refactored to make use of BoundsCalculator methods for calculating bounds. Commit: d947407ccb4f06596b8e13637adbda5b52e218ed https://github.com/cdk/cdk/commit/d947407ccb4f06596b8e13637adbda5b52e218ed Author: Arvid Berg <gog...@gm...> Date: 2012-05-19 (Sat, 19 May 2012) Changed paths: M src/main/org/openscience/cdk/renderer/ChemModelRenderer.java Log Message: ----------- Use paint(drawVisitor,diagram) from ChemModelRenderer and not AbstractRenderer This is important because you can only access the drawCenter on the outer renderer and the paint method needs to be called on the same object. Commit: fd4ec82a0c0e8e2311fce4c8533873e2765f4bdd https://github.com/cdk/cdk/commit/fd4ec82a0c0e8e2311fce4c8533873e2765f4bdd Author: Arvid Berg <gog...@gm...> Date: 2012-05-19 (Sat, 19 May 2012) Changed paths: M src/main/org/openscience/cdk/renderer/MoleculeSetRenderer.java Log Message: ----------- Always needs to register the parameters from the generators to the renderer model Commit: 8cae7b23ca93331a77f1bc3e136b47a598313638 https://github.com/cdk/cdk/commit/8cae7b23ca93331a77f1bc3e136b47a598313638 Author: Arvid Berg <gog...@gm...> Date: 2012-05-19 (Sat, 19 May 2012) Changed paths: M src/main/org/openscience/cdk/renderer/MoleculeSetRenderer.java Log Message: ----------- Avoid NPE when trying to calcualate diagram bound on an empty molecule set. Commit: fe6807d0e0293d90d51cf89737d75595108394a7 https://github.com/cdk/cdk/commit/fe6807d0e0293d90d51cf89737d75595108394a7 Author: Egon Willighagen <ego...@gm...> Date: 2012-05-19 (Sat, 19 May 2012) Changed paths: M src/main/org/openscience/cdk/renderer/generators/ReactionPlusGenerator.java Log Message: ----------- Only draw + signs when there is more than one entity Commit: d71024e9212fbc06e91de7278434c64db475f5ec https://github.com/cdk/cdk/commit/d71024e9212fbc06e91de7278434c64db475f5ec Author: Egon Willighagen <eg...@us...> Date: 2012-05-19 (Sat, 19 May 2012) Changed paths: M src/META-INF/test-renderextra.devellibdepends Log Message: ----------- Any JUnit version is fine Change-Id: I41ff972dce78b12528d01f3a8f073c3c0deb3b95 Compare: https://github.com/cdk/cdk/compare/cf897ab...d71024e |