From: SourceForge.net <no...@so...> - 2011-06-21 08:27:46
|
Patches item #3323501, was opened at 2011-06-21 01:12 Message generated for change (Comment added) made by egonw You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=320024&aid=3323501&group_id=20024 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: master Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Asad (asadrahman) Assigned to: Nobody/Anonymous (nobody) Summary: SMSD patch Initial Comment: SMSD patch with latest code a) Isomorphism b) Substructure search c) Thread safe ---------------------------------------------------------------------- >Comment By: Egon Willighagen (egonw) Date: 2011-06-21 10:27 Message: Asad, this is a massive patch. Just in the first 4% I see numerous problems. Have you run the CDK QA system against it? Please do. I know this is painful work, but we all have to do it. The current patch has way to much I would comment on, for me to review this patch in the next weeks. Solving all OpenJavaDocCheck, PMD, JUnit (coverage) problem will very much help. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=320024&aid=3323501&group_id=20024 |