From: Rajarshi G. <raj...@gm...> - 2011-05-30 12:50:59
|
On May 30, 2011, at 6:33 AM, Egon Willighagen wrote: > Hi Rajarshi, > > On Sun, May 29, 2011 at 11:18 PM, Rajarshi Guha <raj...@gm... > > wrote: >> I've been browsing the patch on github and one general recommendation >> I'd have is to make as much of the classes as possible into package >> private? Currently, most (all?) of the classes are public - but as >> far >> as I can tell are targeted to the rendering machinery. From the users >> PoV, I think the public API can be very minimal. > > How does that work? Many classes are down in subpackages... e.g. > cdk.renderer.elements. Classes in those packages are indeed not aimed > at general use, but if we make those non-public (no modifier), they > can no longer be accessed from other cdk.renderer.* subpackages > either... Ahh, of course. But where possible, it would be good to reduce the public API. On a related note, it might be useful to generate Javadocs that hide parts of the api - is that possible? ---------------------------------------------------- Rajarshi Guha | NIH Chemical Genomics Center http://www.rguha.net | http://ncgc.nih.gov ---------------------------------------------------- A bug in the hand is better than one as yet undetected. |