From: SourceForge.net <no...@so...> - 2011-01-15 17:00:17
|
Patches item #3158047, was opened at 2011-01-14 12:10 Message generated for change (Comment added) made by egonw You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=320024&aid=3158047&group_id=20024 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None >Group: Accepted >Status: Closed >Resolution: Accepted Priority: 5 Private: No Submitted By: Dmitry Katsubo (dma_k) Assigned to: Egon Willighagen (egonw) Summary: generateCoordinates() should throw CDKException Initial Comment: The provides patch fixes this small case. ---------------------------------------------------------------------- >Comment By: Egon Willighagen (egonw) Date: 2011-01-15 18:00 Message: Looks good to me. Next time, it would be even better to leave the removal of the (now) redundant casting for another patch. That way, the commit message would more properly reflect the patch. Applied to cdk-1.4.x. ---------------------------------------------------------------------- Comment By: Dmitry Katsubo (dma_k) Date: 2011-01-14 16:11 Message: Commit in Git: https://github.com/dmak/cdk/commit/53ee4b64aa802db381d32a0ddfceaf02e87e9c00 ---------------------------------------------------------------------- Comment By: Egon Willighagen (egonw) Date: 2011-01-14 12:46 Message: Yes, looks good to me. Can you convert that into a git patch? (We'll chat about that on IRC...) ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=320024&aid=3158047&group_id=20024 |