[Cdk-devel] [ cdk-Patches-3043569 ] CIP subset implementation

[SourceForge.net <no...@so...>]

Patches item #3043569, was opened at 2010-08-12 10:57
Message generated for change (Comment added) made by egonw
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=320024&aid=3043569&group_id=20024

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
>Category: cdk-1.4.x
Group: Needs Review
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Egon Willighagen (egonw)
Assigned to: Nobody/Anonymous (nobody)
Summary: CIP subset implementation

Initial Comment:
Based on the recent ITetrahedralChirality work, I have implemented a patch to determine R,S based on a subset of the CIP rules.

Aimed at master, review very much appreciated.

There are four methods that are reported not tested, caused by a limitation of the coverage testing:

3033072	CoverageAnnotationTest gives false positives on compare()

The JavaDoc report shows a lot of false positives in the spell checking (that Jazzy patch should be removed, but accidentally sneaked in with another patch), but also a few false positives due to CDK checks happening on inner classes:

3043084	OJDC checks should not run on inner classes


----------------------------------------------------------------------

>Comment By: Egon Willighagen (egonw)
Date: 2010-10-17 23:40

Message:
Rebased the patch on cdk-1.4.x.

----------------------------------------------------------------------

Comment By: Egon Willighagen (egonw)
Date: 2010-08-13 17:32

Message:
Gilleain found an issue in my code, fixed by the patches 0002 and 0003.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=320024&aid=3043569&group_id=20024