[Cdk-devel] [ cdk-Patches-2961963 ] Performance tuning for NNChemObject

[SourceForge.net <no...@so...>]

Patches item #2961963, was opened at 2010-03-02 15:53
Message generated for change (Comment added) made by egonw
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=320024&aid=2961963&group_id=20024

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
>Group: Needs Revision
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Stefan Kuhn (shk3)
>Assigned to: Stefan Kuhn (shk3)
Summary: Performance tuning for NNChemObject

Initial Comment:
I found that even calling the notifyChanged method and checking doNotify
is a performance bottleneck on flags and properties, if these change
frequently. This patch makes NNChemObject no longer call notifyChanged
at all. Some field in ChemObject need to go protected for this, but I
think this is ok.

----------------------------------------------------------------------

>Comment By: Egon Willighagen (egonw)
Date: 2010-03-05 11:33

Message:
This needs a more permanent fix, and this really begs for a split up of the
IChemObject interface into a notifying part and a unnotifying part... I
have been working on a patch about 6 months ago or so... then, the NN
classes can be rewritten from scratch (by copy/paste followed by hacking
away bits) to not extend the default 'data' classes and not implement to
INotifyingChemObject...

I am not so happy about the change of ChemObject's fields... what about
just duplicating those fields in NNChemObject? They are lazy initialized
anyway, so counts only for two pointers and not two data models... then you
do not need to touch the ChemObject class at all...

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=320024&aid=2961963&group_id=20024