[Cdk-devel] [ cdk-Patches-2883189 ] updateHydrogenCount in AbstractEdit

[SourceForge.net <no...@so...>]

Patches item #2883189, was opened at 2009-10-21 14:32
Message generated for change (Settings changed) made by shk3
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=320024&aid=2883189&group_id=20024

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
>Status: Closed
>Resolution: Out of Date
Priority: 5
Private: No
Submitted By: Stefan Kuhn (shk3)
Assigned to: Goglepox (goglepox)
Summary: updateHydrogenCount in AbstractEdit

Initial Comment:
Arvid, I have tried to make the AbstractEdit actually update the hydrogen count in the updateHydrogenCount method. Unfortunately, this requires some larger changes and it would be good, I think, if we can work this out together. The patch is probably not perfect, this is because I am not 100% sure about your design. Ok, so:
- I removed the atomsToUpdate attribute from AbstractEdit and the getter from IEdit. This is not used anywhere I can't see why keeping this collection is usefull.
- The abstractEdit does the update, note this is a copy and paste from ControllerHub. ControllerHub is supposed to loose that code anyway, but we could make this a helper method, that's no problem.
- For the update, you need the AtomContainer the atom is in, not just the atom (this is to get bond count etc.) So I added an AtomContainer attribute to AbstractEdit. If this is not set, nothing is done.
- The implementing classes, if they want to have the update done (some do not change anything relevant anyway, like the move) need to set this. I changed the constructor of relevant classes to take an AtomContainer alongside the atom.
Ok, so have a look and I am sure we can work this out.

----------------------------------------------------------------------

Comment By: Stefan Kuhn (shk3)
Date: 2009-10-21 15:28

Message:
commit is 876859b68d9939123ed4ee41250e02d172cc5939

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=320024&aid=2883189&group_id=20024