From: Stefan K. <ste...@eb...> - 2009-10-20 10:26:07
|
> 7d64167c1294bc399b36b6784dab605d718cf8ca > OK, but: (Let me know if you are OK if I change that in the patch, > before I apply to 1.3.x) > * suggest to use IBond.Stereo instead of CDKConstants (which should be > removed) * suggest to use String.contains instead of indexOf() != -1 These are ok. Constants should indeed go. I assumed you did this, but if not I strongly suggest to do so, because it's the only way to make sure they do not accidentally used somewhere. Stefan > > Egon -- Stefan Kuhn B. Sc. M. A. Software Engineer in the Chemoinformatics and Metabolism Team European Bioinformatics Institute (EBI) Wellcome Trust Genome Campus Hinxton, Cambridge CB10 1SD UK Phone +44 1223 49 2657 Fax +44 (0)1223 494 468 |