From: <ma...@eb...> - 2009-10-05 17:11:51
|
Thanks for the explanation.. I'm not sure I have an opionion right now regarding the updateView(), I'll look at the classes you mention a bit more. Regarding the fix, how/where could I get r14926 ? Mark > updateView() is a very general event, the Move edit that is generated in > the > drag part of the MoveModule > fires a coordinates changed event. It is not clear to me who should be > responsible for sending the update view event, > right now we have two event handlers the IViewEventRelay and the > IChemModelEventRelayHandler. The IViewEventRealy > interface only handles the updateView event while > IChemModelEventRelayHandler has several including coordinate-, zoom-, > structure-changed events. > > The solution is either to fire a updateView() whenever a > IChemModelVentRelayHandler event is fired or let the individual > IChemModelEventRelayHanler implementors handle it them selves. The later > is > how JChemPaintPanel dose in the case of a structure changed event, > and indirectly how Bioclipse dose it right now. > > The errors when undoing was my fault and is fixed in r14926 > > /Arvid |