[Cdk-devel] [ cdk-Patches-2797822 ] reaction properties in cml

[SourceForge.net <no...@so...>]

Patches item #2797822, was opened at 2009-05-28 12:23
Message generated for change (Comment added) made by egonw
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=320024&aid=2797822&group_id=20024

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
>Group: Accepted
>Status: Closed
>Resolution: Fixed
Priority: 5
Private: No
Submitted By: Miguel Rojas Cherto (miguelrojasch)
Assigned to: Miguel Rojas Cherto (miguelrojasch)
Summary: reaction properties in cml

Initial Comment:
The the Convertor(writer cml) and the CMLCoreModule(reader cml) classes doesn't implement the functionality to parse reaction property informations. For that we need a cdk:reactionProperty DictRef specific for reactions. 

The CMLReaction should have the appendChild including CMLScalar scheme.

----------------------------------------------------------------------

>Comment By: Egon Willighagen (egonw)
Date: 2009-07-21 22:56

Message:
Damn... wrong report... Please disregard my previous message...

This one is fine, and applied to master.

----------------------------------------------------------------------

Comment By: Egon Willighagen (egonw)
Date: 2009-07-21 22:54

Message:
Miguel,

the patch is sort of fine, but I'll reject it in the current form as it
uses isRef, which must not be a global variable, because that breaks
compatibility with multithreading... we need to fix that first...

----------------------------------------------------------------------

Comment By: Egon Willighagen (egonw)
Date: 2009-06-09 12:21

Message:
Miguel, can you please attach the patch to this tracker entry?

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=320024&aid=2797822&group_id=20024