From: Stefan K. <ste...@eb...> - 2009-07-21 13:40:59
|
On Tuesday 21 July 2009 13:52:19 Stefan Kuhn wrote: > On Friday 17 July 2009 18:55:02 Egon Willighagen wrote: > > On Fri, Jul 17, 2009 at 6:28 PM, Stefan Kuhn<ste...@eb...> wrote: > > > Please find attached a patch for the jchempain-primary branch in git. > > > > Please split up patches according to the module they are in, so that I > > can put things in the right patch set. > > Find the patches attached. I just found there is a problem with the patch, it uses calculateAverageBondLength from Renderer, on which module the controlbasic module does not depend. It seems the same problem existed with AddBondDragModule, where it was solved by adding a method calculateAverageBondLength, which is effectivly a copy from GeometryTools. I would suggest to add a calculateAverageBondLength(ChemModel) method to GeometryTools and use these from AddBondDragModule and AddAtomModule. Stefan -- Stefan Kuhn B. Sc. M. A. Software Engineer in the Chemoinformatics and Metabolism Team European Bioinformatics Institute (EBI) Wellcome Trust Genome Campus Hinxton, Cambridge CB10 1SD UK Phone +44 1223 49 2657 Fax +44 (0)1223 494 468 |