From: gilleain t. <gil...@gm...> - 2009-04-30 19:28:44
|
Hmmm. Unfortunately this test only passes because the molecule returned by the Mol2Reader has no atoms. So the string generated by the smiles generator is empty. In any case, this test would pass even when you use the MDLReader (I don't know why this works, when the Mol2 doesn't - another bug?) as the smiles from wikipedia is not the same as the smiles generated for alpha-pinene. Sorry, this is my fault - Stefan did tell me to write a unit test for this, and I shouldn't have lazily let Rajarshi write it :) Oh, and a final thing is that the hydrogens have to be removed. I should have done that to the molfile, really. Sorry again. gilleain On Thu, Apr 30, 2009 at 7:39 PM, Rajarshi Guha <rg...@in...> wrote: > The attached patch checks bug 2784343 in which an alpha pinene isomer is > ending up with the same SMILES as alpha pinene. > > However the test indicates this is not the case > > > ------------------------------------------------------------------- > Rajarshi Guha <rg...@in...> > GPG Fingerprint: D070 5427 CC5B 7938 929C DD13 66A1 922C 51E7 9E84 > ------------------------------------------------------------------- > Q: What's polite and works for the phone company? > A: A deferential operator. > > > ------------------------------------------------------------------------------ > Register Now & Save for Velocity, the Web Performance & Operations > Conference from O'Reilly Media. Velocity features a full day of > expert-led, hands-on workshops and two days of sessions from industry > leaders in dedicated Performance & Operations tracks. Use code vel09scf > and Save an extra 15% before 5/3. http://p.sf.net/sfu/velocityconf > _______________________________________________ > Cdk-devel mailing list > Cdk...@li... > https://lists.sourceforge.net/lists/listinfo/cdk-devel > > |