[Cdk-devel] [ cdk-Patches-1864371 ] CDKException instantions should keep stack trace

[SourceForge.net <no...@so...>]

Patches item #1864371, was opened at 2008-01-05 09:02
Message generated for change (Comment added) made by egonw
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=320024&aid=1864371&group_id=20024

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: Needs Review
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Egon Willighagen (egonw)
Assigned to: Nobody/Anonymous (nobody)
Summary: CDKException instantions should keep stack trace

Initial Comment:
There are several CDKException instantiations which look like:

new CDKException("Error occured during clone " + e);

Such calls are wrong in two ways:

1.the new error message should contain the error message of the parent exception:

"Error occured during clone " + e.getMessage

But, this report is really about keeping the stack trace, which is done by adding the catched exception 'e' as second parameter to the CDKException constructor:

new CDKException("Error occured during clone " + e.getMessage(), e);


----------------------------------------------------------------------

>Comment By: Egon Willighagen (egonw)
Date: 2009-04-27 08:43

Message:
Patch looks fine to me.

----------------------------------------------------------------------

Comment By: Egon Willighagen (egonw)
Date: 2009-01-19 15:09

Message:
Open for review.

----------------------------------------------------------------------

Comment By: Egon Willighagen (egonw)
Date: 2009-01-19 15:09

Message:
Moving to Patches.

----------------------------------------------------------------------

Comment By: paul turner (paulturner)
Date: 2009-01-19 13:33

Message:
branch ready for merge.

oops:please excuse the email i sent instead of putting comment here.

----------------------------------------------------------------------

Comment By: paul turner (paulturner)
Date: 2009-01-03 20:23

Message:
paulturner: have started work on this one... work area is
branches/paulturner-jj1864371

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=320024&aid=1864371&group_id=20024