Re: [Cdk-devel] summary of my latest patches

[Rajarshi G. <rg...@in...>]

On Apr 24, 2009, at 9:05 AM, Miguel Rojas Cherto wrote:

> On Fri, 2009-04-24 at 08:41 -0400, Rajarshi Guha wrote:
>> 1. http://rguha.net/tmp/0001-Converted-cdk.svnrev-tags-to-cdk.githash-tags.patch
>>
>> This updates all source files that contained a cdk.svnrev tag to
>> instead use cdk.githash tag. Note that the new tag doesn't have an
>> argument
>>
>> 2. http://rguha.net/tmp/0002-Updated-SVN-taglet-to-generate-links-to-the-HEAD-of.patch
>>
>> This updates the SVN taglet to check for cdk.githash tags and  
>> generate
>> a link to the source file on SF, located in HEAD. (We can't easily
>> link to a specific commit hash via post-commit hooks - hence we just
>> link into HEAD)
>
> Why didn't you create a new function called CDKGITTaglet instead of
> modifying CDKSVNTaglet in the class CDKSVNTaglet. I think it creates
> confusion. I don't know how much work that it would take.


Yes, I initially thought of that, but then decided to minimize changes  
and just modify the source. I was planning to make the name change in  
a separate patch, if these went in

-------------------------------------------------------------------
Rajarshi Guha  <rg...@in...>
GPG Fingerprint: D070 5427 CC5B 7938 929C  DD13 66A1 922C 51E7 9E84
-------------------------------------------------------------------
Q:  What's polite and works for the phone company?
A:  A deferential operator.