Re: [Cdk-devel] Looking for null functions

[Noel O'B. <bao...@gm...>]

> ./qsar/descriptors/molecular/AutocorrelationDescriptorMass.java has
> 2 match(es)

> Why is the above file in error? The two methods are:

> public Object getParameterType(String name)
> public Object[] getParameters()

> So if the descriptor has no params, returning null seems to make
> sense. (One could argue that the second method should return Object[]
> {}, but is that an issue?)

Sure - maybe it's fine - I didn't check before posting. But a quick
check of another descriptor, AtomCountDescriptor, shows that its
behaviour is different - it returns an empty string instead. This sort
of consistency is one of the sorts of things a unit test is good at,
e.g. a quick loop over all descriptors to verify that they are
behaving.

- Noel