[Cdk-devel] [ cdk-Patches-1837692 ] Test methods should throw only one Exception

[SourceForge.net <no...@so...>]

Patches item #1837692, was opened at 2007-11-24 18:38
Message generated for change (Comment added) made by egonw
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=320024&aid=1837692&group_id=20024

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: Needs Review
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Egon Willighagen (egonw)
>Assigned to: paul turner (paulturner)
Summary: Test methods should throw only one Exception

Initial Comment:
At this moment, there is much code like:

public void testBB() throws ClassNotFoundException, CDKException, java.lang.Exception {

This can and should be simplified to:

public void testBB() throws Exception {

----------------------------------------------------------------------

>Comment By: Egon Willighagen (egonw)
Date: 2009-01-21 13:14

Message:
Stefan, it is only in the unit tests, where JUnit is the only thing
downstream... throws Exception would indeed not be good as part of the CDK
API.

Paul, does this patch only change things in test classes, or also in the
main CDK library? I admit that my JJ description was not particularly clear
on that.

----------------------------------------------------------------------

Comment By: Stefan Kuhn (shk3)
Date: 2009-01-21 12:01

Message:
Forgive me for suggesting this late, but I don't think throws Exception is
good. We should only have the specific exceptions thrown. I agree that
throws A, B, Exception isn't good, but it should become throws A, B, C, D,
imho.

----------------------------------------------------------------------

Comment By: Egon Willighagen (egonw)
Date: 2009-01-19 14:46

Message:
Everyone, this patch is up for review. Please leave your comments here, or
as "// FIXME: jj1837692: fix this and this" or "// TODO: jj1837692: I
suggest you ..." in the source code.

----------------------------------------------------------------------

Comment By: Egon Willighagen (egonw)
Date: 2009-01-19 13:36

Message:
OK, moving it to the Patches tracker.

----------------------------------------------------------------------

Comment By: paul turner (paulturner)
Date: 2009-01-19 13:32

Message:
branch ready for merge.

oops:please excuse the email i sent instead of putting comment here.

----------------------------------------------------------------------

Comment By: paul turner (paulturner)
Date: 2009-01-01 14:19

Message:
I'll start working on this one.  work area is
branches/paulturner-juniorjobs.  


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=320024&aid=1837692&group_id=20024