Re: [Cdk-devel] [Cdk-commits] SF.net SVN: cdk:[12817] cdk/branches/cdk-1.2.x/src/test/org/openscience/cdk /qsar/descriptors/molecular

[Rajarshi G. <rg...@in...>]

On Oct 26, 2008, at 4:10 PM, Egon Willighagen wrote:

> On Sun, Oct 26, 2008 at 9:07 PM,  <raj...@us...>  
> wrote:
>>     @Before
>> -    protected void setUp() throws Exception {
>> +    public void setUp() throws Exception {
>>         setDescriptor(ALOGPDescriptor.class);
>>         hydrogenAdder = CDKHydrogenAdder.getInstance 
>> (DefaultChemObjectBuilder.getInstance());
>>     }
>
> There also is @BeforeClass... though I guess it makes sense to create
> a new descriptor for each test method, wrt to parameters... but
> certainly this is not needed for th hydrogen adder, but that's a
> singleton anyway...

True - my updates were automated, so I missed stuff like that.

However I purposely used the @Before annotation, since using  
@BeforeClass means that the same set up code is used for all tests -  
and I have been bitten by the fact that one test may leave the inputs  
in a state not expected by another test.

While using @Before rather than @BeforeClass, may be a little  
inefficient, the tests are meant for devs, so I think the peace of  
mind is worth it :)

-------------------------------------------------------------------
Rajarshi Guha  <rg...@in...>
GPG Fingerprint: D070 5427 CC5B 7938 929C  DD13 66A1 922C 51E7 9E84
-------------------------------------------------------------------
All science is either physics or stamp collecting.
	-- Ernest Rutherford