Re: [Cdk-devel] Smiles parser leaves massNumber null

[Egon W. <ego...@gm...>]

On Thu, Jun 12, 2008 at 5:58 PM, Rajarshi Guha <rg...@in...> wrote:
>> Egon, shouldn't the AbstractRenderer2D check whether the mass number
>> is UNSET? Only if it's UNSET should it try generating isotope labels.

Yes, it should indeed. I guess there is more code that does not do
this properly... please be aware if changes in behaviour, and please
report those... (if possible, even write a unit test...)

> I have gone and updated the renderer in trunk so that it checks
> whether the mass number has been set or not. In the latter case, it
> will not generate isotope labels. This allows one to skip the above
> isotope configuration step

Thanx.

BTW, the AbstractRenderer2D will be removed from trunk soon, but you
did apply this to trunk, right?

Egon

-- 
----
http://chem-bla-ics.blogspot.com/