[Cdk-devel] merging/deprecating SMARTS parsers

[Rajarshi G. <rg...@in...>]

On Oct 23, 2007, at 11:55 AM, Egon Willighagen wrote:

>> 2. The non-JJTree SMARTS parser. Given that the JJTree parser has
>> fewer bugs, etc, it makes sense to remove the other parser. This
>> would also make the SMARTS package cleaner - currently it's confusing
>> to see two parsers in similar paths
>
> Ummm... this might actually deserve a full separate email... is there
> nothing in the other version left that is not dealt with the JJTree
> version?

At least from the point of view of bugs

smiles.smarts.SmartsParser.jj - 85 Junit failures (in ParserTest.java)

smiles.smarts.parser.SmartsParser.jjt - 2 Junit failures (in  
RecursiveTest.java and the two failures are due to H addition/ 
aromaticity perception issues and 0 in ParserTest.java)

I don't think the non-JJTree parser handles recursive SMARTS - I may  
be wrong

-------------------------------------------------------------------
Rajarshi Guha  <rg...@in...>
GPG Fingerprint: 0CCA 8EE2 2EEB 25E2 AB04  06F7 1BB9 E634 9B87 56EE
-------------------------------------------------------------------
Science kind of takes the fun out of the portent business.
                 -Hobbes