From: Clifford Y. <cli...@gm...> - 2013-10-23 11:50:17
|
On Wed, Oct 23, 2013 at 6:37 AM, Daniel Roßberg <dan...@gm...> wrote: >> I propose in advance of GCI that we establish style enforcement as part of >> the build so that we don't have to personally discuss / explain style >> issues. Basically, we'd integrate a style check that would run during >> compilation. If a file fails our style check, it results in a compilation >> error. > > I would like to have a CMake variable to switch it off. I'm afraid > MSVC needs another day to compile with this check because of slow file > operations. Agreed - I'm currently using ENABLE_STYLE_VALIDATION, which we could eventually make default to the value of the BRLCAD_ENABLE_STRICT+CMAKE_BUILD_TYPE=Debug settings and allow the user to override (similar to how we handle BRLCAD_EXTRADOCS_VALIDATE - in fact, the final variable should probably be BRLCAD_STYLE_VALIDATE to make the BRLCAD_EXTRADOCS_VALIDATE) Cheers, CY |