Re: [brlcad-devel] [GSoC] A patch of ell_brep.cpp

[Clifford Y. <cli...@gm...>]

On Tue, Apr 3, 2012 at 12:54 AM, phoenix <284...@qq...> wrote:

> Hi,
> > Nice work and thanks for breaking out the separate conversions into
> separate patch files so they're easier to review independently.  The only
> thing I noticed right away is that the indentation is wrong (I believe your
> editor is injecting literal tabs).  The include/ws.sh and include/indent.sh
> (or M-x indent-region in Emacs) might help.  Otherwise, nice example of a
> patches relevant to the task you're interested in working on.
> **
>
> Thanks for your advises. I have adjusted the indentation of the patch
> files and updated them at sourceforge.net. Are they OK now?
>
> Cheers,
> Wu Jianbang
>

Wu,

Something you may want to add to your proposal is the implementation of a
convenient way to take a given CSG primitive and generate its BREP form.

There are a number of possible ways to do that - one way that might be
fairly quick and convenient would be to add an additional option to the
"brep" debugging command that already exists to accept a CSG primitive name
and (optionally) an output name for the brep to be generated, and have it
put the generated brep in the current open database.  There are others, and
Sean may have some thoughts here as well, but you will definitely need
something of the sort for evaluating the conversion routines so it's
something to call out in your proposal if you can.

Cheers,
CY