[brlcad-tracker] [ brlcad-Feature Requests-1680710 ] Improve const-correctness

[SourceForge.net <no...@so...>]

Feature Requests item #1680710, was opened at 2007-03-14 15:13
Message generated for change (Comment added) made by elfring
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=640805&aid=1680710&group_id=105292

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Compilation
Group: Minor Effort
>Status: Open
Resolution: Accepted
Priority: 1
Private: No
Submitted By: Markus Elfring (elfring)
Assigned to: Sean Morrison (brlcad)
Summary: Improve const-correctness

Initial Comment:
Would you like to apply the advices from the article "http://en.wikipedia.org/wiki/Const-correctness" to more places in your sources?
I suggest to add the key word "const" to the type specifiers for parameters like the following.
- http://brlcad.cvs.sourceforge.net/brlcad/brlcad/src/adrt/libcommon/canim.h?revision=1.10&view=markup
  frames_file (function "common_anim_read")

- http://brlcad.cvs.sourceforge.net/brlcad/brlcad/src/adrt/libcommon/env.h?revision=1.9&view=markup
  fpath (function "common_env_read")

- http://brlcad.cvs.sourceforge.net/brlcad/brlcad/src/conv/g-vrml.c?revision=14.19&view=markup
  vrml_mat_parse, usage (global "variables")

----------------------------------------------------------------------

>Comment By: Markus Elfring (elfring)
Date: 2007-03-20 21:28

Message:
Logged In: YES 
user_id=572001
Originator: YES

Will the file "g-vrml.c" be updated, too?
Are you going to clarify more APIs in a similar way?

----------------------------------------------------------------------

Comment By: Sean Morrison (brlcad)
Date: 2007-03-20 20:35

Message:
Logged In: YES 
user_id=785737
Originator: NO

We regularly perform code cleanups like the sort you suggested here,
though generally just fixing and cleaning up as we run into them during
development.  Constantly refactoring.  We could certainly use more cleanup
like this if you are interested in becoming more directly involved.

Thanks for pointing those particular cases out, they have been fixed.

Cheers!
Sean


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=640805&aid=1680710&group_id=105292