Re: [Blitz-support] problems compiling with g++ 4.3.3 in redhat version

[Mario E. <ma...@em...>]

Hi again,

Mario Emmenlauer wrote:
>> We still have an issue. We get
>>
>> cc1plus: warnings being treated as errors
>> In file included from /usr/local/blitz09/include/blitz/array-impl.h:43,
>>                  from /usr/local/blitz09/include/blitz/array.h:32,
>>                  from blitzBenchMark.cpp:5:
>> /usr/local/blitz09/include/blitz/range.h: In member function ‘bool 
>> blitz::Range::isAscendingContiguous() const’:
>> /usr/local/blitz09/include/blitz/range.h:126: error: suggest parentheses 
>> around && within ||
> 
> Well, anyways, I can fix them, the warnings don't appear in many places
> according to my previous tests. Consider it done, but I can not send out
> the patch before beginning of next week (due to lack of time).


This is interesting, in my version of blitz++ (latest CVS + 64bit
changes from LMB freiburg), the corresponding section reads:

   bool isAscendingContiguous() const
   {
     return (((first_ < last_) && (stride_ == 1)) || (first_ == last_));
   }

So there are parantheses around && within ||. I browsed a bit around
the code, and could not find other places where the parantheses would be
wrong.
Are you using the tar archive of blitz0.9, or a CVS checkout? If you don't
have done so yet, could you try the latest CVS snapshot of blitz++? The
release 0.9 is quite old now...

All the best,

    Mario