From: Kern S. <ke...@si...> - 2003-11-05 13:23:33
|
On Wed, 2003-11-05 at 13:26, Phil Stracchino wrote: > On Wed, Nov 05, 2003 at 09:21:42AM +0100, Kern Sibbald wrote: > > On Tue, 2003-11-04 at 19:52, Dan Langille wrote: > > > Sorry for starting a new thread on this one, but I'm on a different > > > machine without access to my regular email. > > > > > > I have looked into this issue. Here are the permissions added when Bacula > > > must create the directory specified as the WHERE parameter to a restore > > > job. The problem is all directories shold have o+x,g+x and they do not. > > > > Why do you say that Bacula should have those permissions? If > > I remember right, on directories that are not saved but must > > be created (because they are a parent directory), I use the > > minimum permissions possible. > > > I have a possibly-simple suggestion here. > > In order to correctly restore files and directories to their *original* > locations with correct permissions, Bacula has a record of the original > permissions on backed-up directories and files. So why not simply add > an option to Restore jobs, "Use original permissions for newly created > files and directories" (or something like that), which forces the > original permissions to be used even if restoring to a different > location? Your proposal makes a lot of sense. However, implementing it would not be so easy. When Bacula creates these directories, it is nested way down deep in the bowels of the restore code, which knows nothing at all about Bacula, the Director and all that. I would prefer, at this stage, not to complicate the existing code, but to figure out what is most correct as things currently work. First, is there really anything wrong with the way it does it now? Also should Bacula create those directories with the same permissions as the lowest level directory it is creating, should Bacula add execute permission for group and other as Dan is suggesting. Finally it also might be worth while to see how "mkdir -p" works. I will definitely add to my todo list that creation of new directories should see if they are saved and use those options. Note, however, even doing that doesn't solve the problem for the "bacula-restores" directory if you haven't done a previous restore, or you are not backing up /tmp. |