[Bacula-bugs] [bacula 0000621]: Jobs that define "Max Run Time" are silently canceled

[<bac...@li...>]

A BUGNOTE has been added to this bug.
======================================================================
http://bugs.bacula.org/bug_view_advanced_page.php?bug_id=0000621
======================================================================
Reported By:                shattered
Assigned To:                
======================================================================
Project:                    bacula
Bug ID:                     621
Category:                   Director
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     feedback
======================================================================
Date Submitted:             05-24-2006 00:14 PDT
Last Modified:              05-25-2006 11:01 PDT
======================================================================
Summary:                    Jobs that define "Max Run Time" are silently canceled
Description: 
To backup "system state" of Windows servers, we invoke ntbackup.exe in
ClientRunBeforeJob.  On a certain server, ntbackup would run forever,
stalling the job queue.  

We tried a workaround (Max Run Time = 1 hour), but then the director
silently canceled the job.
======================================================================

----------------------------------------------------------------------
 kern - 05-24-2006 07:04 PDT 
----------------------------------------------------------------------
I'd like to see the output of your Job where the director cancels the job.
In carefully looking at the code, when the Director (actually the
watchdog) cancels a Job, it sends an INFO message to the Job report.  If
the user cancels a Job, the output is sent to the console.

It is possible that there is a bug, but I do not believe so.

----------------------------------------------------------------------
 shattered - 05-24-2006 07:29 PDT 
----------------------------------------------------------------------
There was no output at all -- not on console nor in log file; not even a
normal "Start Backup JobId ..." message.  Perhaps they were suppressed?

Messages {
  Name = Standard
  mailcommand = "/pkg/sbin/bsmtp -h localhost -f \"\(Bacula\) %r\" -s
\"Bacula: %t %e of %c %l\" %r"
  operatorcommand = "/pkg/sbin/bsmtp -h localhost -f \"\(Bacula\) %r\" -s
\"Bacula: Intervention needed for %j\" %r"
  mail = root@... = all, !skipped
  operator = root@... = mount
  console = all, !skipped, !saved, !restored
  append = "/.../log" = all, !skipped
}

----------------------------------------------------------------------
 kern - 05-24-2006 07:46 PDT 
----------------------------------------------------------------------
Bacula *never* suppresses output, and I have never heard it happen before.
However, you must properly configure it. I'll leave it to you to check
your Messages resource and possibly ask on the bacula-users list what is
wrong. In taking a quick glance, I see nothing, but then /.../log is not
valid -- I suppose you are just suppressing confidential info.

I'm closing this bug. If you can show me a job report where the
information is not included, or if you can define exactly when Bacula is
suppressing output then please resubmit the bug or re-open this one.

----------------------------------------------------------------------
 shattered - 05-25-2006 00:56 PDT 
----------------------------------------------------------------------
Sorry, I've forgot to mention an important detail.  This job's priority is
lower than default (15 vs. 10), and it normally stays in queue for several
hours.  When started from console (with no other jobs in queue), it
completes just fine.

Perhaps job_check_maxruntime() should check that jcr->start_time is
nonzero?

   if ((watchdog_time - jcr->start_time) < jcr->job->MaxRunTime) {
      Dmsg3(200, "Job %p (%s) with MaxRunTime %d not expired\n",
            jcr, jcr->Job, jcr->job->MaxRunTime);
      return false;
   }

----------------------------------------------------------------------
 kern - 05-25-2006 10:10 PDT 
----------------------------------------------------------------------
Hmmm. Yes, that *is* an important detail, and if Bacula is zapping a job
that is still waiting to start, it looks like a bug.

I'll take a careful look at the code that you point out ...

----------------------------------------------------------------------
 kern - 05-25-2006 11:01 PDT 
----------------------------------------------------------------------
I've looked at the code, and what you suggest is not possible.
jcr->start_time should *always* be non-zero immediately when the job is
started, even if it is held in the job queue for a long time.

Bug History
Date Modified  Username       Field                    Change              
======================================================================
05-24-06 00:14 shattered      New Bug                                      
05-24-06 07:04 kern           Bugnote Added: 0001691                       
05-24-06 07:04 kern           Status                   new => feedback     
05-24-06 07:29 shattered      Bugnote Added: 0001693                       
05-24-06 07:46 kern           Bugnote Added: 0001694                       
05-24-06 07:46 kern           Resolution               open => unable to duplicate
05-24-06 07:46 kern           Status                   feedback => closed  
05-25-06 00:56 shattered      Bugnote Added: 0001697                       
05-25-06 00:56 shattered      Resolution               unable to duplicate => reopened
05-25-06 00:56 shattered      Status                   closed => feedback  
05-25-06 10:10 kern           Bugnote Added: 0001701                       
05-25-06 11:01 kern           Bugnote Added: 0001702                       
======================================================================