[Bacula-bugs] [Bacula Bug Reports 0002086]: Worker thread count is incorrect in case if start_server routine returns failure

[Mantis B. T. <no...@bu...>]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.bacula.org/view.php?id=2086 
====================================================================== 
Reported By:                ajay_kolambekar
Assigned To:                
====================================================================== 
Project:                    Bacula Bug Reports
Issue ID:                   2086
Category:                   Director
Reproducibility:            have not tried
Severity:                   minor
Priority:                   normal
Status:                     new
====================================================================== 
Date Submitted:             2014-07-29 07:34 BST
Last Modified:              2014-07-29 07:50 BST
====================================================================== 
Summary:                    Worker thread count is incorrect in case if
start_server routine returns failure
Description: 
This bug was found during code review.

In function "jobq_server" from jobq.c 

431             if (start_server(jq) != 0) {
432                jq->num_workers--;
433                V(jq->mutex);
434                return NULL;

It is not required to call jq->num_workers-- if start_server fails. 

Steps to Reproduce: 
NA
====================================================================== 

---------------------------------------------------------------------- 
 (0007013) ajay_kolambekar (reporter) - 2014-07-29 07:50
 http://bugs.bacula.org/view.php?id=2086#c7013 
---------------------------------------------------------------------- 
Not a bug. It can be closed. 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2014-07-29 07:34 ajay_kolambekarNew Issue                                    
2014-07-29 07:50 ajay_kolambekarNote Added: 0007013                          
======================================================================