[Bacula-bugs] [bacula 0001879]: VSS Code interprets a success message as an Error

[Mantis B. T. <no...@bu...>]

The following issue has been SUBMITTED. 
====================================================================== 
http://bugs.bacula.org/view.php?id=1879 
====================================================================== 
Reported By:                tezza2k1
Assigned To:                
====================================================================== 
Project:                    bacula
Issue ID:                   1879
Category:                   Win32 File Daemon (client)
Reproducibility:            always
Severity:                   major
Priority:                   normal
Status:                     new
====================================================================== 
Date Submitted:             2012-05-31 13:39 BST
Last Modified:              2012-05-31 13:39 BST
====================================================================== 
Summary:                    VSS Code interprets a success message as an Error
Description: 
Sometimes, but not always, Windows decides to return an error value from its
functions. However this error value is actually saying that it is a success (!!)

So unix style checking for any return value representing an error does not work.

You get the following error:

VSSClientGeneric::Initialize: CreateVssBackupComponents returned 0x80070005.
ERR=The operation completed successfully.

--------

Personally in my code I check for a return value and then also check the value
of GetLastError() .

E.g:

	ret = bind( s, (SOCKADDR *) &dest, sizeof(dest) );
	if(ret) {
		DWORD err = GetLastError();
		if(!err) { /* there can be a return value, but no error */
			ret = 0;
		}


Steps to Reproduce: 
Vista 64bit File Daemon

Files Set with Enable Vss = yes
====================================================================== 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2012-05-31 13:39 tezza2k1       New Issue                                    
======================================================================