Re: [Bacula-devel] [PATCH] - Modify makebacularel to use tar.bz2 like docs etc

[Eric B. <eri...@ba...>]

Hello Bruno,

On 09/25/2011 04:21 PM, Bruno Friedmann wrote:
> Find a small patch modifying makebacularel, config and sign to
> use tar.bz2 as default source format

Why do you want to change the default source format? I'm not sure we 
discussed this before. I'm pretty sure that it will break all packager 
scripts such as spec files. I think that it's too late for this release 
to make such changes.

> config is modified to make folders less "bee"

I'm sorry, but your patch is changing how these scripts are used. For 
example, it looks like (I'm not 100% sure) that we would need to use a 
parameter to the makebacularel script.

-bacula=${bacula:-${HOME}/bee/bacula}
-docs=${docs:-${HOME}/bee/docs}
+bacula=${bacula:-$1}
+docs=${docs:-$1/../docs}

If you want to use a specific value for $bacula, you just have to put 
your configuration in a file such as config.bruno and parse it before.

export bacula=$HOME/bacula
export docs=$HOME/docs
...

I don't see the need for your change, the script is already quite 
flexible on this part.

> config export now GPGKEY so other key can be use to sign package
>   useful for us, preparing the rpm for community and when we want to create intermediate release (-dev)
> sign source config

This part looks to be good, if you provide a patch with this 
modification, I would apply it.

Thanks,

Bye
-- 
Need professional help and support for Bacula ?
Visit http://www.baculasystems.com