[Bacula-commits] SF.net SVN: bacula:[7420] trunk/bacula

[<ke...@us...>]

Revision: 7420
          http://bacula.svn.sourceforge.net/bacula/?rev=7420&view=rev
Author:   kerns
Date:     2008-07-23 08:25:20 +0000 (Wed, 23 Jul 2008)

Log Message:
-----------
Make the default bat restore Pool be Any. This fixes bug #1118.

Modified Paths:
--------------
    trunk/bacula/src/qt-console/restore/prerestore.cpp
    trunk/bacula/technotes-2.5

Added Paths:
-----------
    trunk/bacula/patches/2.4.1-bat-restore.patch

Added: trunk/bacula/patches/2.4.1-bat-restore.patch
===================================================================
--- trunk/bacula/patches/2.4.1-bat-restore.patch	                        (rev 0)
+++ trunk/bacula/patches/2.4.1-bat-restore.patch	2008-07-23 08:25:20 UTC (rev 7420)
@@ -0,0 +1,68 @@
+
+ This patch should fix bug #1118 where bat does not restore correctly
+ if multiple pools were used. Bat actually works correctly, but the default
+ Pool is taken from the Job resource, and for multiple pools the default
+ should be Any. This patch makes Any the default restore pool.
+ Apply it to version 2.4.1 with:
+
+ cd <bacula-source>
+ patch -p0 <2.4.1-bat-restore.patch
+ ./configure <your-options>
+ make
+ ...
+ make install
+
+ 
+Index: src/qt-console/restore/prerestore.cpp
+===================================================================
+--- src/qt-console/restore/prerestore.cpp	(revision 7414)
++++ src/qt-console/restore/prerestore.cpp	(working copy)
+@@ -1,7 +1,7 @@
+ /*
+    Bacula® - The Network Backup Solution
+ 
+-   Copyright (C) 2007-20087 Free Software Foundation Europe e.V.
++   Copyright (C) 2007-2008 Free Software Foundation Europe e.V.
+ 
+    The main author of Bacula is Kern Sibbald, with contributions from
+    many others, a complete list can be found in the file AUTHORS.
+@@ -20,7 +20,7 @@
+    Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
+    02110-1301, USA.
+ 
+-   Bacula® is a registered trademark of John Walker.
++   Bacula® is a registered trademark of Kern Sibbald.
+    The licensor of Bacula is the Free Software Foundation Europe
+    (FSFE), Fiduciary Program, Sumatrastrasse 25, 8006 Zürich,
+    Switzerland, email:ft...@fs....
+@@ -146,7 +146,7 @@
+    cmd += " fileset=\"" + filesetCombo->currentText() + "\"";
+    cmd += " client=\"" + clientCombo->currentText() + "\"";
+    if (selectJobRadio->isChecked()) {
+-      if (poolCombo->currentText() != "Any" ){
++      if (poolCombo->currentText() != tr("Any") ){
+          cmd += " pool=\"" + poolCombo->currentText() + "\"";
+       }
+       cmd += " storage=\"" + storageCombo->currentText() + "\"";
+@@ -171,12 +171,10 @@
+       Pmsg1(000, "preRestore command \'%s\'\n", cmd.toUtf8().data());
+    }
+    m_console->write_dir(cmd.toUtf8().data());
+-// consoleCommand(cmd);
+ 
+    /* Note, do not turn notifier back on here ... */
+    if (selectFilesRadio->isChecked()) {
+       setConsoleCurrent();
+-//    new restorePage();
+       closeStackPage();
+    } else {
+       closeStackPage();
+@@ -210,7 +208,7 @@
+    if (m_console->get_job_defaults(job_defs)) {
+       filesetCombo->setCurrentIndex(filesetCombo->findText(job_defs.fileset_name, Qt::MatchExactly));
+       clientCombo->setCurrentIndex(clientCombo->findText(job_defs.client_name, Qt::MatchExactly));
+-      poolCombo->setCurrentIndex(poolCombo->findText(job_defs.pool_name, Qt::MatchExactly));
++      poolCombo->setCurrentIndex(poolCombo->findText(tr("Any"), Qt::MatchExactly));
+       storageCombo->setCurrentIndex(storageCombo->findText(job_defs.store_name, Qt::MatchExactly));
+    }
+ }

Modified: trunk/bacula/src/qt-console/restore/prerestore.cpp
===================================================================
--- trunk/bacula/src/qt-console/restore/prerestore.cpp	2008-07-23 08:23:02 UTC (rev 7419)
+++ trunk/bacula/src/qt-console/restore/prerestore.cpp	2008-07-23 08:25:20 UTC (rev 7420)
@@ -1,7 +1,7 @@
 /*
    Bacula® - The Network Backup Solution
 
-   Copyright (C) 2007-20087 Free Software Foundation Europe e.V.
+   Copyright (C) 2007-2008 Free Software Foundation Europe e.V.
 
    The main author of Bacula is Kern Sibbald, with contributions from
    many others, a complete list can be found in the file AUTHORS.
@@ -146,7 +146,7 @@
    cmd += " fileset=\"" + filesetCombo->currentText() + "\"";
    cmd += " client=\"" + clientCombo->currentText() + "\"";
    if (selectJobRadio->isChecked()) {
-      if (poolCombo->currentText() != "Any" ){
+      if (poolCombo->currentText() != tr("Any") ){
          cmd += " pool=\"" + poolCombo->currentText() + "\"";
       }
       cmd += " storage=\"" + storageCombo->currentText() + "\"";
@@ -171,12 +171,10 @@
       Pmsg1(000, "preRestore command \'%s\'\n", cmd.toUtf8().data());
    }
    m_console->write_dir(cmd.toUtf8().data());
-// consoleCommand(cmd);
 
    /* Note, do not turn notifier back on here ... */
    if (selectFilesRadio->isChecked()) {
       setConsoleCurrent();
-//    new restorePage();
       closeStackPage();
    } else {
       closeStackPage();
@@ -210,7 +208,7 @@
    if (m_console->get_job_defaults(job_defs)) {
       filesetCombo->setCurrentIndex(filesetCombo->findText(job_defs.fileset_name, Qt::MatchExactly));
       clientCombo->setCurrentIndex(clientCombo->findText(job_defs.client_name, Qt::MatchExactly));
-      poolCombo->setCurrentIndex(poolCombo->findText(job_defs.pool_name, Qt::MatchExactly));
+      poolCombo->setCurrentIndex(poolCombo->findText(tr("Any"), Qt::MatchExactly));
       storageCombo->setCurrentIndex(storageCombo->findText(job_defs.store_name, Qt::MatchExactly));
    }
 }

Modified: trunk/bacula/technotes-2.5
===================================================================
--- trunk/bacula/technotes-2.5	2008-07-23 08:23:02 UTC (rev 7419)
+++ trunk/bacula/technotes-2.5	2008-07-23 08:25:20 UTC (rev 7420)
@@ -32,6 +32,8 @@
 
 
 General:
+23Jul08
+kes  Make the default bat restore Pool be Any. This fixes bug #1118.
 22Jul08
 kes  Remove debug statement that crashes the SD at the end of
      a tape during restore. Fixes bug #1125.


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.