From: john s. <js9...@ya...> - 2002-06-01 21:08:04
|
> > The patch worked! I tested on a small directory > that > > I create to test with and it worked. I'll try a > full > > back up later tonight, it takes a few hours to run > a > > full backup, so I won't know until tomorrow if it > > worked 100%. The full backup worked. All of my hard linked files now appear as part of the backup. > > It's not quite right, since the CGI script and > BackupPC_tarCreate don't > understand the hardlink attribute that this patch > writes to disk. > You're right. But at least the file gets backed up and I can restore it (even though the hard link doesn't point back to the previously hard linked file). At least I know it exists and I can get it back if it became corrupt. I figured getting the hard links to work correctly was one of the additional code things you needed to do. > > I would like to see a hard link replaced by a hard > > link instead of individual files, but only if one > of > > the original files already existed. That will be > an > > interesting programming feat. > > Yes, the real fix for v1.5.0 will be more clever. > For example, consider > the case of three files A, B, C which are all > identical, and A and B are > hardlinked, but C is not. With my current patch all > files will be turned > into hardlinks to a single pool file, and when you > restore you will get > three identical, but not hardlinked, files. v1.5.0 > will do the right > thing: only a single file will be stored, but when > you restore you > will get two files (A,B) that are hardlinked, and a > third file, C, > that is identical but not linked. Awesome!! That's what I'd expect to see. > > Anyhow, in the meantime please replace my previous > patch with this > one. It will produce attributes compatible with the > CGI script > and BackupPC_tarCreate. Does it hurt to leave it the way your original patch did it? I'd like to see the files that are hard linked so that I know they were that way before they were backed up. I may not know to which file they were linked to, but with the "?" in the file type field I can at least assume that the file was hard linked at one point. > > Craig > Thanks again John Stanley __________________________________________________ Do You Yahoo!? Yahoo! - Official partner of 2002 FIFA World Cup http://fifaworldcup.yahoo.com |