From: Craig B. <cba...@us...> - 2006-07-29 17:16:31
|
Rodrigo Real writes: > I found one more bug, pretty the same, but in another file. >=20 > The same problem was ocurring when I tried to restore any file inside > a directory with accents in its name. I followed the same logic and > the patch below seemed to solve that. Thanks, you're right. I've added your patch. I'm going to do some more testing of rsync/rsyncd/smb/tar restore and also test backup with sharename/exclude/include settings that have non-ascii characters. As Vincent notes there are likely some combinations that don't work because of a missing charset conversion. Here's some background to the other readers on this list on what has changed here. In 2.x BackupPC didn't know about the client's file name character encoding. Although the round-trip backup/restore worked (since the same sequence of bytes in each file name was delivered during restore), the file names often would not be displayed correctly, and it was problematic to support share names, include and exclude file lists with the right character encoding. In 3.x the server does everything in utf8 and conversion to/from the clients charset is done during backup and restore. What we're debugging is making sure all the cases have the correct coversion. Craig |