[BackupPC-devel] 2.0.0beta1 patches

[Timothy D. <dem...@ar...>]

Craig:

Here are the bug fix patches in context diff format. I cleaned them up so 
they apply nicely against fresh 2.0.0beta1 sources. Included are the 
promised patches for doing color hilighting on the PC Summary CGI page. I 
tested a fresh install here and they appear to work fine. The included 
README is at the end of this message.

One thing I removed was the   hack from each cell. I'm working on a 
cleaner way of doing this and will submit patches for it later.

Tim

--
Timothy Demarest                      ArrayComm, Inc.
dem...@ar...                2480 North 1st Street, Suite 200
http://www.arraycomm.com              San Jose, CA 95131


There are 3 patches that are meant to be applied against a clean
BackupPC-2.0.0beta1 source tree:

BackupPC_Admin.array-reference.patch
BackupPC_dump.dhcp-netbios.patch
color-hilighting.patches

Untar the BackupPC-2.0.0beta1.tar.gz file and apply the patches in any 
order:

tar xzvf BackupPC-2.0.0beta1.tar.gz
cd BackupPC-2.0.0beta1
patch -p0 < patchname


------------------
PATCH DESCRIPTIONS
------------------

------------------------------------
BackupPC_Admin.array-reference.patch
------------------------------------

Fixes a problem with the Command Queue Summary display -- there is an array
reference which is not dereferenced correctly. This view without the patch
looks like:

>From the CGI: <http://bertha/cgi-bin/BackupPC_Admin?action=queue>
...
Command Queue Summary

The following command requests are currently queued:
Host    Req Time    User      Command
dell58  4/11 03:59  BackupPC  ARRAY(0x8593eb0)


The patch fixes the array reference:

The following command requests are currently queued:
Host     Req Time    User      Command
dell128  4/14 10:16  BackupPC  BackupPC_link dell128
dell44   4/14 09:14  BackupPC  BackupPC_link dell44


--------------------------------
BackupPC_dump.dhcp-netbios.patch
--------------------------------

The symptom is that *no* DHCP backups start. You can submit a request
for a manual backup, and it will say that it was accepted, but nothing
happens - no error is logged either.

A little investigating shows that one line should have a variable change
from "$host" to "$client".

This patch is only required if you are still using the dhcp option. The
dhcp option has been deprecated in favor of nmb multicast lookups.

------------------------
color-hilighting.patches
------------------------

Applies patches to conf/config.pl, lib/BackupPC/Lang/en.pm, and
cgi-bin/BackupPC_Admin to enable (subtle) table row color hilighting in the
CGI PC Summary page, which helps to visualize the status of your clients
especially if the client list is large.

The configuration variable in conf/config.pl - $Conf{DisplayColorHilites} -
enables or disables the use of color hilites, and after the patch is
applied it defaults to "yes".

The colors can be changed in the library file lib/BackupPC/Lang/en.pm:

  # Color hilighting for states
  $Lang{Hilite_backup_failed} = "#ffcccc";
  $Lang{Hilite_backup_done} = "#ccffcc";
  $Lang{Hilite_no_ping} = "#ffff99";
  $Lang{Hilite_backup_in_progress} = "#66cc99";
  $Lang{Hilite_backup_canceled_by_user} = "#ff9900";

Currently only hilighting for a few states is done.

The BackupPC_Admin gets patched to selectively display the hilighting
depending on the value of $Conf{DisplayColorHilites}.