From: Rich R. <ri...@sh...> - 2007-12-05 19:04:05
|
John Pettitt wrote: >> >> > What happens is the newly transfered file is compared against candidates > in the pool with the same hash value and if one exists it's just > linked, The new file is not compressed. It seems to me that if you > want to change the compression in the pool the way to go is to modify > the BackupPC_compressPool script which compresses an uncompressed pool > to instead re-compress a compressed pool. There is some juggling that > goes on to maintain the correct inode in the pool so all the links > remain valid and this script already does that. > > You're sure? That isn't my observation. At least with rsync, the files in the 'new' subdirectory of the backup are already compressed, and I vaguely recall reading the code and noticing it compresses them during the transfer (but on the server side as it receives the data). After the whole rsync session is finished, then the NewFiles hash list is compared with the pool. Identical files (determined by hash code of uncompressed data) are then linked to the pool. If that is all true, then it seems like there is an opportunity to compare the size of the existing file in the pool with the new file, and keep the smaller one. Rich |