From: Linda K. <lin...@hp...> - 2012-01-09 17:37:38
|
James Czyzak wrote: > Hi Miroslav > > I had to apply the patch by hand because my email system always screws up > the in-line patches. Not sure why but no matter. The patches got me > further but then I ran into the problem where the hard coded restorecon > instructions of those files got me. So just for a quick test I removed > those on my test machine for the reset and rom file since it doesn't > affect my system. That got me considerable further. The problem now > appears that the attach itself fails and it seems that the system is > claiming an internal error not wanting to do the bus reset because the > device I specified (eth1 at 0000:04:00.1) shares the bus with eth0 (at > 0000:04:00.0) which of course is my primary ethernet device which I am > logged in through . I get the same error if I try to configure the test to use one port of my 4-port NIC. 03:00.0 Ethernet controller: Broadcom Corporation NetXtreme II BCM5709 Gigabit Ethernet (rev 20) 03:00.1 Ethernet controller: Broadcom Corporation NetXtreme II BCM5709 Gigabit Ethernet (rev 20) 04:00.0 Ethernet controller: Broadcom Corporation NetXtreme II BCM5709 Gigabit Ethernet (rev 20) 04:00.1 Ethernet controller: Broadcom Corporation NetXtreme II BCM5709 Gigabit Ethernet (rev 20) I tried using 04.00.0, which is unused on my system, and based on the error messages I assume I'm just out of luck because 04.00.1 exists, even though it is also unused. What's interesting is that I'm able to get the tests to work on a different system using a Qlogic adapter, that looks like this: 07:00.0 Fibre Channel: QLogic Corp. ISP2432-based 4Gb Fibre Channel to PCI Express HBA (rev 02) 07:00.1 Fibre Channel: QLogic Corp. ISP2432-based 4Gb Fibre Channel to PCI Express HBA (rev 02) The tests pass if pci_device="0000:07:00.0". In this case it doesn't seem to have a problem with assigning a PCI device, even though there is another device on the same bus? Maybe the problem is that 04:00.1 isn't really unused? -- ljk > So I guess my question now is should the tests be run > on devices attached to a bus that are not active? I believe I have > additional ethernet devices on this target machine but I don't on my 2nd > target machine the 3620M3 (However it runs an intel chipset so it may be > different in operation anyway). Here is the section of messages in the > run.log from the first test that include the error message. I can send the > entire run.log if necessary. I guess what I'm curious about now is whether > not having those 2 files is detrimental to doing this operation? > > Here are the messages surrounding the error that occurs (notice it no > longer tries to restorecon on the files reset or rom because I commented > out those commands) > > " restorecon -RvvvF /sys/bus/pci/devices/0000:04:00.1/config; > restorecon -RvvvF /sys/bus/pci/devices/0000:04:00.1/resource*; > /bin/rm -f guest1.xml; > /usr/bin/virsh nodedev-reattach pci_0000_04_00_1 > /sbin/restorecon -RvvvF /sys/bus/pci/devices/0000:04:00.1/config > /sys/bus/pci/devices/0000:04:00.1/resource > /sys/bus/pci/devices/0000:04:00.1/resource0 > }' > + attach_pci_device 1 guest1 guest1 guest2 > + local rc=0 > + case $1 in > + /usr/bin/virsh attach-device guest1 pci_dev.xml > error: Failed to attach device from pci_dev.xml > error: internal error Unable to reset PCI device 0000:04:00.1: internal > error Active 0000:04:00.0 devices on bus with 0000:04:00.1, not doing bus > reset > > + (( rc+=1 )) > + sleep 3 > + check_device_driver pci-stub" > > Shortly after this (although there are a number more operations and > messages) it goes to exit_fail 'Attach failed' > > I may try this with the ethernet devices on the card that has nothing > attached to it, or maybe even get off eth0 and run the test from the > console. My question on either of those options is "If I do that am I > defeating the purpose of the test?" > > Thanks > Jim > > James Czyzak > Linux Security Team > Linux Technology Center > (830) 839-4826 > cz...@us... > > > > > From: Miroslav Vadkerti <mva...@re...> > To: James Czyzak/Beaverton/IBM@IBMUS > Cc: aud...@li... > Date: 01/09/2012 06:53 AM > Subject: Re: [PATCH 1/1] kvm-iommu PCI PT rom and reset files not > required > > > > > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Hi James, > > could you try out this patch if it fixes your issues with KVM PCI PT tests > please? We currently do not have a installed machine to try it out. > > Thanks, > /M > > On 01/09/2012 01:50 PM, mva...@re... wrote: >> From: Miroslav Vadkerti <mva...@re...> >> >> >> Signed-off-by: Miroslav Vadkerti <mva...@re...> >> --- >> audit/kvm-iommu/test_pci_passthrough.bash | 16 ++++++++++++++++ >> 1 files changed, 16 insertions(+), 0 deletions(-) >> >> diff --git a/audit/kvm-iommu/test_pci_passthrough.bash > b/audit/kvm-iommu/test_pci_passthrough.bash >> index d324dee..40e52b0 100755 >> --- a/audit/kvm-iommu/test_pci_passthrough.bash >> +++ b/audit/kvm-iommu/test_pci_passthrough.bash >> @@ -263,6 +263,14 @@ check_pci_device_dynamic() { >> # go through all required pci device files >> for dfile in $(ls > /sys/bus/pci/devices/$pci_device/{config,resource*,rom,reset}); >> do >> + # rom and reset files may not exist, if so skip them and log to > run.log >> + # http://www.kernel.org/doc/Documentation/filesystems/sysfs-pci.txt >> + # http://www.kernel.org/doc/Documentation//ABI/testing/sysfs-bus-pci >> + if [ ! -e $dfile ]; then >> + echo "$FUNCNAME: ### INFO ### - skipping not existing file $dfile" >> + continue >> + fi >> + >> owner=$(stat -c "%U:%G" $dfile) >> label=$(stat -c "%C" $dfile) >> >> @@ -275,6 +283,14 @@ check_pci_device_dynamic() { >> # go through all required pci device files >> for dfile in $(ls > /sys/bus/pci/devices/$pci_device/{config,resource*,rom,reset}); >> do >> + # rom and reset files may not exist, if so skip them and log to > run.log >> + # http://www.kernel.org/doc/Documentation/filesystems/sysfs-pci.txt >> + # http://www.kernel.org/doc/Documentation//ABI/testing/sysfs-bus-pci >> + if [ ! -e $dfile ]; then >> + echo "$FUNCNAME: ### INFO ### - skipping not existing file $dfile" >> + continue >> + fi >> + >> owner=$(stat -c "%U:%G" $dfile) >> label=$(stat -c "%C" $dfile) >> > > > - -- > Miroslav Vadkerti :: QA Engineer / RHCE :: BaseOS QE - Security > IRC mvadkert at #qe #urt #rpmdiff :: GnuPG ID 0x25881087 at pgp.mit.edu > Phone +420 532 294 129 :: CZ +420 775 039 842 :: SK +421 904 135 440 > Red Hat s.r.o, Purky?ova 99/71, 612 45, Brno, Czech Republic > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v1.4.11 (GNU/Linux) > Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ > > iQEcBAEBAgAGBQJPCuMTAAoJEBliWhMliBCHxk8IAMVfxu8UtJLhvs4Bx0+G5Q7u > crrKb19gLU+wqnmnhD68zfW+M0NivH6jRNhQJq6Q9eQHppMZ57Zmo5NLUtXRRLLG > rJiMqj8wVBg2TahpPtl91wDsGgbeGTVtnpXp+R7c0BDmzM01Zj0boD6w74wcXMQt > oe7kq49XA/FRMaUNeXhRyEXyT+nAfDX6/jsiVDxXAHYfAKu3F5I3ckNT+IZK5kUY > P9kWxOGfgG4nRDRjP+EX/4NvujqWdnqPrJe8J0EQ86lhl+ViOtHf3nviX+m4PWO7 > 9T9VBLbxS9f3OwAwsESmfoKCpZLrStRLweSIodaNADBFhicyDonbsbDRDR1KvC0= > =ba67 > -----END PGP SIGNATURE----- > > > > > > ------------------------------------------------------------------------ > > ------------------------------------------------------------------------------ > Ridiculously easy VDI. With Citrix VDI-in-a-Box, you don't need a complex > infrastructure or vast IT resources to deliver seamless, secure access to > virtual desktops. With this all-in-one solution, easily deploy virtual > desktops for less than the cost of PCs and save 60% on VDI infrastructure > costs. Try it free! http://p.sf.net/sfu/Citrix-VDIinabox > > > ------------------------------------------------------------------------ > > _______________________________________________ > Audit-test-developer mailing list > Aud...@li... > https://lists.sourceforge.net/lists/listinfo/audit-test-developer |