Re: [Audit-test-developer] [PATCH 1/3] Use LOCAL_SEC_DEV instead of SECNET_SVR_DEV

[Miroslav V. <mva...@re...>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi James,

I made a patch to correct an issue I recently found
with the netfilebt tests. The issue is only visible
when SECNET_SVR_DEV != LOCAL_SEC_DEV

Can you please confirm I'm correct here?

Thanks and regards,
/M

On 12/15/2011 02:08 PM, mva...@re... wrote:
> From: Miroslav Vadkerti <mva...@re...>
>
> The correct interface attached to the bridge on TOE
> is LOCAL_SEC_DEV not SECNET_SVR_DEV. This change
> is needed for the netfilebt tests to successfully PASS.
> This problem is not visible if LOCAL_SEC_DEV == SECNET_SVR_DEV.
>
> Signed-off-by: Miroslav Vadkerti <mva...@re...>
> ---
> audit/netfilebt/run.conf | 10 ++++------
> 1 files changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/audit/netfilebt/run.conf b/audit/netfilebt/run.conf
> index 1f0fcce..34e9408 100644
> --- a/audit/netfilebt/run.conf
> +++ b/audit/netfilebt/run.conf
> @@ -383,7 +383,7 @@ function setup_default {
> sendrand_tcp)
> if [[ $ipv == "ipv6" ]]; then
> if [[ $local_ipv6_prefix == "fe80" ]]; then
> - local_host="$LOCAL_SEC_IPV6%$SECNET_SVR_DEV"
> + local_host="$LOCAL_SEC_IPV6%$LOCAL_SEC_DEV"
> echo " $local_host "
> else
> local_host="$LOCAL_SEC_IPV6"
> @@ -398,7 +398,7 @@ function setup_default {
> sendrand_udp)
> if [[ $ipv == "ipv6" ]]; then
> if [[ $local_ipv6_prefix == "fe80" ]]; then
> - local_host="$LOCAL_SEC_IPV6%$SECNET_SVR_DEV"
> + local_host="$LOCAL_SEC_IPV6%$LOCAL_SEC_DEV"
> echo " $local_host "
> else
> local_host="$LOCAL_SEC_IPV6"
> @@ -609,7 +609,6 @@ function run_test {
> if [[ $PPROFILE = lspp ]] ; then
> expect -c'
> spawn run_init service ebtables restart
> - expect "Authenticating ccteam."
> expect "Password:"
> sleep 1
> send "$env(PASSWD)\r"
> @@ -624,7 +623,7 @@ function run_test {
>
> case $tnum in
> 2)
> - ebtables -I INPUT 1 -i $SECNET_SVR_DEV -j AUDIT_DROP
> + ebtables -I INPUT 1 -i $LOCAL_SEC_DEV -j AUDIT_DROP
> ebtables -L --Ln
> ;;
> 4)
> @@ -687,7 +686,7 @@ function run_test {
> ebtables -L --Ln
> ;;
> 22)
> - ebtables -I INPUT 1 -i $SECNET_SVR_DEV -j AUDIT_DROP
> + ebtables -I INPUT 1 -i $LOCAL_SEC_DEV -j AUDIT_DROP
> ebtables -L --Ln
> ;;
> 24)
> @@ -829,7 +828,6 @@ function run_test {
> if [[ $PPROFILE = lspp ]] ; then
> expect -c'
> spawn run_init service ebtables restart
> - expect "Authenticating ccteam."
> expect "Password:"
> sleep 1
> send "$env(PASSWD)\r"


- -- 
Miroslav Vadkerti :: QA Engineer / RHCE :: BaseOS QE - Security
IRC mvadkert at #qe #urt #rpmdiff :: GnuPG ID 0x25881087 at pgp.mit.edu
Phone +420 532 294 129 :: CZ +420 775 039 842 :: SK +421 904 135 440
Red Hat s.r.o, Purky?ova 99/71, 612 45, Brno, Czech Republic
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJO6fI0AAoJEBliWhMliBCHh7UH/i9ZMfASyJW411jYTHtxNttM
lmAdQlO7li2TQEBaU3yDLQkLb2jD1LY7YNJ73/pXx9BBClFq+4RPezmLqyfkx6ms
NYDHKzZ9lv2pz5wx0rYZ0kzNxVnU/F+7/UYjaqQe1e5zr7ohmCpfWYefM/wIjkqR
zvgSF8DP1+HxIeMPdCdt10wFUaxEStBIAxTwYcpg0GMnuX/jF19g5a9dbmkgbRR+
JGQ1aspstRnheWHDAuKzWhyGHjP7T9l/kESF4HidsI9kc9VttceZYoZoazKoAOtn
b+TMZoTNDVrPlFa3XKza+6ECzWfrjstE/zwSQdobhG5O/oiBkjGPXmNEBjLlffM=
=I3ms
-----END PGP SIGNATURE-----