Re: [Audit-test-developer] [PATCH 4/5] Added kvm-iommu tests and configuration

[Eduard B. <eb...@re...>]

On 10/05/2011 07:53 PM, Linda Knippers wrote:
> Hi Miroslav,
> 
> I'm going to pull this in but I have a question below.
> 
> -- ljk
> 
> mva...@re... wrote:
>> From: Miroslav Vadkerti <mva...@re...>
>>
>>
>> Signed-off-by: Miroslav Vadkerti <mva...@re...>
>> ---
>>  audit/kvm-iommu/Makefile        |   20 +++++++++++++
>>  audit/kvm-iommu/pci_device.conf |   16 +++++++++++
>>  audit/kvm-iommu/run.conf        |   57 +++++++++++++++++++++++++++++++++++++++
>>  3 files changed, 93 insertions(+), 0 deletions(-)
>>  create mode 100644 audit/kvm-iommu/Makefile
>>  create mode 100644 audit/kvm-iommu/pci_device.conf
>>  create mode 100644 audit/kvm-iommu/run.conf
>>
>> diff --git a/audit/kvm-iommu/Makefile b/audit/kvm-iommu/Makefile
>> new file mode 100644
>> index 0000000..13acbc5
>> --- /dev/null
>> +++ b/audit/kvm-iommu/Makefile
>> @@ -0,0 +1,20 @@
>> +###############################################################################
>> +#   Copyright (c) 2011 Red Hat, Inc. All rights reserved.
>> +#
>> +#   This program is free software: you can redistribute it and/or modify
>> +#   it under the terms of version 2 the GNU General Public License as
>> +#   published by the Free Software Foundation.
>> +#
>> +#   This program is distributed in the hope that it will be useful,
>> +#   but WITHOUT ANY WARRANTY; without even the implied warranty of
>> +#   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>> +#   GNU General Public License for more details.
>> +#
>> +#   You should have received a copy of the GNU General Public License
>> +#   along with this program.  If not, see <http://www.gnu.org/licenses/>.
>> +###############################################################################
>> +
>> +TOPDIR		= ..
>> +SUB_DIRS	=
>> +
>> +include $(TOPDIR)/rules.mk
>> diff --git a/audit/kvm-iommu/pci_device.conf b/audit/kvm-iommu/pci_device.conf
>> new file mode 100644
>> index 0000000..ef141b3
>> --- /dev/null
>> +++ b/audit/kvm-iommu/pci_device.conf
>> @@ -0,0 +1,16 @@
>> +#
>> +# PCI device for testing PCI passthrough (PCI PT)
>> +#
>> +# Please set a device the supports PCI PT. Not all devices
>> +# behave correctly with this test.
>> +#
>> +# Tested devices that work well with this test:
>> +# Ethernet controller: Intel Corporation 82576 Gigabit Network Connection (rev 01)
>> +# Ethernet controller: Broadcom NetXtreme II BCM5708S Gigabit Ethernet
>> +#
>> +# Command line hints how to find a suitable PCI device:
>> +# $ lspci
>> +# $ virsh nodedev-list --tree
>> +# $ virsh nodedev-dumpxml pci_0000_03_00_0
>> +#
>> +pci_device="0000:03:10.5"
> 
> Since the pci_device is something the tester has to configure for
> each system, would it be better to have an obvious placeholder (like
> XX:XX:XX.X) in this assignment statement, rather than a pci device that 
> might actually exist on the system?  I'd like to to be obvious if someone 
> misses a configuration step.  In this case, the results could vary depending
> on whether there happens to be something at that pci address.

Yes, this is a good suggestion to use XX:XX:XX.X instead of a something 
that might match a real device on a system. Do you need another patch?

>> diff --git a/audit/kvm-iommu/run.conf b/audit/kvm-iommu/run.conf
>> new file mode 100644
>> index 0000000..ec8df16
>> --- /dev/null
>> +++ b/audit/kvm-iommu/run.conf
>> @@ -0,0 +1,57 @@
>> +###############################################################################
>> +#   Copyright (c) 2011 Red Hat, Inc. All rights reserved.
>> +#
>> +#   This copyrighted material is made available to anyone wishing
>> +#   to use, modify, copy, or redistribute it subject to the terms
>> +#   and conditions of the GNU General Public License version 2.
>> +#
>> +#   This program is distributed in the hope that it will be
>> +#   useful, but WITHOUT ANY WARRANTY; without even the implied
>> +#   warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR
>> +#   PURPOSE. See the GNU General Public License for more details.
>> +#
>> +#   You should have received a copy of the GNU General Public
>> +#   License along with this program; if not, write to the Free
>> +#   Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
>> +#   Boston, MA 02110-1301, USA.
>> +###############################################################################
>> +#
>> +# AUTHOR: Eduard Benes <eb...@re...>
>> +#
>> +
>> +run_test() {
>> +    declare status x=$1
>> +    shift
>> +
>> +    # Force the audit log to rotate
>> +    rotate_audit_logs || return 2
>> +
>> +    # Run the test
>> +    "./test_$x.bash" "$@"
>> +    status=$?
>> +
>> +    # Display the log items if it failed
>> +    if [[ $status == 1 ]]; then
>> +        echo
>> +        echo augrok output
>> +        echo -------------
>> +        augrok type!=DAEMON_ROTATE
>> +    fi
>> +
>> +    return $status
>> +}
>> +
>> +# Positive tests for basic sanity
>> ++ pci_passthrough sanity_attach_after_boot
>> ++ pci_passthrough sanity_attach_on_boot
>> ++ pci_passthrough sanity_detach_1
>> ++ pci_passthrough sanity_detach_2
>> +
>> +# Negative tests on a single guest domain
>> ++ pci_passthrough simple_double_attach
>> ++ pci_passthrough simple_double_detach
>> +
>> +# Negative tests on two guest domain
>> ++ pci_passthrough shared_attach_on_boot
>> ++ pci_passthrough shared_attach_used
>> ++ pci_passthrough shared_detach_used
> 
> 
> ------------------------------------------------------------------------------
> All the data continuously generated in your IT infrastructure contains a
> definitive record of customers, application performance, security
> threats, fraudulent activity and more. Splunk takes this data and makes
> sense of it. Business sense. IT sense. Common sense.
> http://p.sf.net/sfu/splunk-d2dcopy1
> _______________________________________________
> Audit-test-developer mailing list
> Aud...@li...
> https://lists.sourceforge.net/lists/listinfo/audit-test-developer