Re: [j-devel] ZipCache.java: an attempt to speed up loading

[Erik H. <eh...@gm...>]

On Sat, Jun 6, 2009 at 9:03 PM, Alessio Stalla <ale...@gm...> wrote:
> On Sat, Jun 6, 2009 at 4:00 PM, Erik Huelsmann<eh...@gm...> wrote:
>> Attached is a patch which implements a ZipCache class: an attempt to
>> speed up our loading.
>>
>> In one of the profiles that I ran over the past days,
>> File.lastModified() consumed up an awful lot of time. With this patch,
>> it's now off the list of hot spots. However: does it really matter, I
>> mean, is loading really faster?
>>
>> Could you try it and tell me your findings? If there's no speed up,
>> there's no reason for the added complexity.
>
> I haven't tried it. However, I noted that in your patch you have
> changed an if test in Stream.java to avoid using indexOf(); the new
> test does not consider the case firstChar == '.' that the original
> code took into account. Is it intended to be like that?

Ah. Thanks for the review; no, it's an error: that change wasn't
supposed to be part of the patch at all.

Since 0.16 is roughly 2 months away, I decided to commit the change
(without the Stream changes); we'll see before 0.16 to pull it or not.


Bye,

Erik.