[Apbs-users] make install broken when using DESTDIR

[Michael B. <mb...@de...>]

Hello,

when you run make install for apbs-0.5.0 with DESTDIR set to e.g.
/home/foo, apbs tries to copy the tools, examples and doc directories to
${prefix} (usually set to /usr/local), which fails if make install isn't
run by root (which is the usual way to build e.g. Debian packages, make
install is run under fakeroot and told to install to a temporary staging
directory via DESTDIR from which the Debian package is assembled).

This could be fixed by changing the top-level Makefile.am to use
$(DESTDIR)${prefix} rather than just ${prefix} in the install-exec-am
rule

However, I don't think ${prefix} is the right directory for those -
creating new directories under /usr or /usr/local directly seems wrong;
e.g. Debian policy mandates that documentation be under
/usr/share/doc/<package> and examples at
/usr/share/doc/<package>/examples.  Why the tools/ directory (containing
source files and Makefiles and all) should be installed as-is to
${prefix} looks even stranger to me, what is the rationale for that?

I suggest to move those to a custom install-rule which is not executed
by `make install', or to move them to ${pkgdatadir}, e.g. (which would
be ${prefix}/share/${PACKAGE_NAME}, so e.g. /usr/share/apbs)


Michael