From: Elias P. <el...@us...> - 2005-05-31 12:49:53
|
On Mon, 2005-05-30 at 23:42 +0200, Evert Glebbeek wrote: > > Updated patch. > > Looks good except for one thing: > > - * Get last character for font. > + * Get one past last character for font. > > The original behavior is the intended (and documented) one, we shouldn't > change it. That probably means there need to be a few more tweaks and fixes > in places where get_font_range_end() is called. > Ah, yes, I grepped for all internal uses of those functions and adjusted them by one. New attempt attached. The "last" variables are now actually the last character, but "end" inside the font structure is one past the last (well, the end :P). For 4.3.x, we might be able to de-confuse this and change it to always use inclusive range, which I agree is more logical - but for now, not worth breaking AllegroGL because of it. Speaking of AllegroGL, this reminds me again, we definitely should try to get Bob to do a synchronized release of AllegroGL when 4.2.0 is released. Judging from allegro.cc, AllegroGL is quite popular, either directly or through OpenLayer, so releasing 4.2.0 with only the CVS AllegroGL working together with it seems strange.. maybe even could have an AllegroGL 0.3.0 (or whatever the next would be) beta1 together with 4.2.0 beta4 (RC1?). The final 0.3.0 could then be delayed after Allegro 4.2.0 in case there are a lot of issues, but at least there would be a version to get along with it (but I don't think there are any issues). -- Elias Pschernig |