[aKregator-devel] [Bug 92597] Konqueror shows binary data as text if the link was opened from an external app

[George S. <st...@kd...>]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
        
http://bugs.kde.org/show_bug.cgi?id=92597        
staikos kde org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From staikos kde org  2004-12-01 10:24 -------
CVS commit by staikos: 

use kapp->invokeBrowser() instead of KRun directly in order to get the right
behaviour and the right KPart for "external browser".  Unfortunately this
doesn't fix the viewing of non-HTML internally.  That's a different bug
though.
BUG: 92597


  M +1 -1      akregator_view.cpp   1.169
  M +9 -3      viewer.cpp   1.27


--- kdenonbeta/akregator/src/akregator_view.cpp  #1.168:1.169
 @ -1144,5 +1144,5  @ void aKregatorView::displayInExternalBro
     if (!url.isValid()) return;
     if (Settings::externalBrowserUseKdeDefault())
-        KRun::runURL(url, "text/html", false, false);
+        kapp->invokeBrowser(url.url(), "0");
     else
     {

--- kdenonbeta/akregator/src/viewer.cpp  #1.26:1.27
 @ -91,5 +91,11  @ void Viewer::displayInExternalBrowser(co
    if (!url.isValid()) return;
    if (Settings::externalBrowserUseKdeDefault())
+   {
+       if (mimetype.isEmpty()) {
+           kapp->invokeBrowser(url.url(), "0");
+       } else {
        KRun::runURL(url, mimetype, false, false);
+       }
+   }
    else
    {
 @ -112,5 +118,5  @ bool Viewer::slotOpenURLRequest(const KU
    if(args.frameName == "_blank" && Settings::mMBBehaviour() == Settings::EnumMMBBehaviour::OpenInExternalBrowser)
    {
-       displayInExternalBrowser(url, "text/html");
+       displayInExternalBrowser(url, QString::null);
        return true;
    }
 @ -173,5 +179,5  @ void Viewer::slotOpenLinkExternal()
 {
    if (m_url.isEmpty()) return;
-   displayInExternalBrowser(m_url, "text/html");
+   displayInExternalBrowser(m_url, QString::null);
 }