[aide-tracker] [ aide-Bugs-2016353 ] aclocal.sh fails to verify version correctly

[SourceForge.net <no...@so...>]

Bugs item #2016353, was opened at 2008-07-11 14:43
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=581579&aid=2016353&group_id=86976

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Compiling aide
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Patrick Horgan (phorgan1)
Assigned to: Nobody/Anonymous (nobody)
Summary: aclocal.sh fails to verify version correctly

Initial Comment:
As an example, I have automake 1.10.1, and automake.sh requires 1.7.  In the check_version() function awk compares 1.7 and 1.10.1 and figures, reasonably, yet incorrectly, that 1.7 is greater than 1.1 and I don't have the prerequisite.  To fix this, you need awk to split 1.7 into 1 and 7, and 1.10.1 into 1 and 10 and 1 and for the length of the shorter compare them.  i.e. compare 1 and 1, then 7 and 10.  If the required version is ever greater then you fail. If they compare equal for the shorter length, then the if the requirement is longer than the actual you have to fail. Here's a version I typed to to make it work for me.  Feel free to use it if you wish.

with this all these would work

required  actual   success?
1.7       1.10.1      Y
1.10      1.10.1      Y
1.10.1    1.10.1      Y
1.10.2    1.10.1      N
1.10.1.1  1.10.1      N

function check_version() {
    if $1 --version |
        awk 'NR==1 { \
            size_needed=split('$2',needed,".");\
            size_got=split($NF,got,".");\
            if(size_needed<size_got)\
                n=size_needed;\
            else;\
                n=size_got;\
            theyareequal=0;\
            for(i=1;i <=n;++i){\
                if(needed[i]!=got[i])\
                    theyareequal=1;\
                if(needed[i]>got[i])\
                    exit 1;\
            }
            if(theyareequal && size_needed > size_got)\
                exit 1;\
            exit 0;\
        }' ; then
        return 0;
    fi
    return 1;
}


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=581579&aid=2016353&group_id=86976