[Acx100-devel] Re: [PATCH] improve configopt, slightly correct acx111 radio recalib

[Denis V. <vd...@il...>]

On Tuesday 10 January 2006 17:11, Andreas Mohr wrote:
> Hi all,
> 
> this patch adds support for configopt parsing for ACX100 EEPROM version v5
> (please report whether ACX100 v5 now works, preferrably with logs showing
> configopt activity).
> 
> Also, we now only start another radio recalibration interval every 5 seconds
> on ACX111 instead of every second (in case of radio recalibration FAILURES,
> that is). 5 recalibration attempts every second in case of repeated failure
> is waaaaay too much, both for undistorted card operation and syslog.

-unsigned int acx_debug = L_ASSOC|L_INIT;
+unsigned int acx_debug __read_mostly = L_ASSOC|L_INIT;

I think __read_mostly is not worth the compat trouble it currently will require
(#ifdef LINUX_VERSION_CODE...).

+       }
+       else
+       {

Changing this to "} else {".

Patch applied, thanks!

BTW, currently we have

        priv->scan_probe_delay = 200;
        /* reported to break scanning: priv->scan_probe_delay = priv->cfgopt_probe_delay; */

Do I need to uncomment that?
--
vda